build: remove hardcoded package release notes from project files#159
Merged
Conversation
The four packable csproj files hardcoded "Initial preview release ..." in PackageReleaseNotes, so every subsequent release would have shipped the same stale notes unless the line was hand-edited each time. Per-release notes are already generated per train by tools/packaging/release-notes.sh and published on the GitHub Release; that pipeline stays the single source of truth. The finding is binder-scoped, but the same frozen line existed in all four packable projects — two of them ship on the same lib train as the binder — so the fix covers all four. Refs: #152 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NuvXSNGbQqxyxMVgJHyX4w
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove hardcoded
PackageReleaseNotesentries from all four project files and replace them with a comment explaining that per-release notes are generated by the release workflow and published on GitHub Releases. This prevents release notes from becoming stale between releases.Type of change
Changes
PackageReleaseNotesfromFirstClassErrors.csprojPackageReleaseNotesfromFirstClassErrors.Cli.csprojPackageReleaseNotesfromFirstClassErrors.RequestBinder.csprojPackageReleaseNotesfromFirstClassErrors.Testing.csprojtools/packaging/release-notes.shand published on GitHub ReleasesTesting
dotnet build FirstClassErrors.slnDocumentation
Architecture decisions
Related issues
https://claude.ai/code/session_01NuvXSNGbQqxyxMVgJHyX4w