Skip to content

Make handler parameter nullable in WpClient constructor (#1) #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jgalea wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Make handler parameter nullable in WpClient constructor (#1) #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/WpClient.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,14 +27,15 @@ class WpClient implements ClientInterface
/**
* Constructor.
*
* @param HandlerInterface $handler The handler to use for dispatching requests and receiving responses.
* @param UriInterface|null $baseUri Optional base URI for all relative requests sent using this client.
* @param HandlerInterface|null $handler The handler to use for dispatching requests and receiving responses.
* Defaults to {@link HandlerStack::createDefault()} when null.
* @param UriInterface|null $baseUri Optional base URI for all relative requests sent using this client.
*
* @throws InvalidArgumentException If the "base_uri" option is present and is not a valid URI.
*/
public function __construct(HandlerInterface $handler, ?UriInterface $baseUri = null)
public function __construct(?HandlerInterface $handler = null, ?UriInterface $baseUri = null)
{
$this->handler = $handler;
$this->handler = $handler ?? HandlerStack::createDefault();
$this->baseUri = $baseUri;
}

Expand Down
Loading