fix: make pause at end of page work with any translation#579
Merged
Conversation
We were excluding sentences that had both class .translation and class .sentence__translation from the list of sentences to figure how which is the last sentence in a page, but we should exclude any sentence with either of those classes, or with do-no-align=true. Depending on how translations are added to a read-along, we don't always set both classes, so let's filter out anything that might be a translation when we are playing in the web-component. Fixes #578
|
Review changes with Changed Files
|
Contributor
|
sergeleger
approved these changes
Jun 26, 2026
sergeleger
left a comment
sergeleger
left a comment
Collaborator
There was a problem hiding this comment.
Bug is fixed, pauses at the end of the first page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Goal?
We were excluding sentences that had both class .translation and class .sentence__translation from the list of sentences to figure how which is the last sentence in a page, but we should exclude any sentence with either of those classes, or with do-no-align=true.
Depending on how translations are added to a read-along, we don't always set both classes, so let's filter out anything that might be a translation when we are playing in the web-component.
Fixes?
Fixes #578
Feedback sought?
sanity checking
Priority?
high
Tests added?
no
How to test?
Confidence?
high
Version change?
We'll want to release this quickly since a user stumbled on it. Let's merge this, then #577, and then let's publish 1.6.4.