Add linear-tail squared activation variants - #889
Open
klei22 wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Adds C1-continuous “linear-tail” variants for squared ReLU-style activations (both as a general activation and as a ReLU2Max softmax alternative), wiring them through configuration/CLI, plus a sweep YAML and targeted tests.
Changes:
- Introduces
SquaredReLULinearandReLU2MaxLinearwith configurable positive cutoffs and linear tails matching value/slope at the cutoff. - Registers the new variants in the activation/softmax dictionaries and exposes new cutoff args via
train_args.pyand defaults viagpt_conf.py. - Adds pytest coverage and an exploration sweep YAML for the new variants.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| variations/softmax_variations.py | Adds ReLU2MaxLinear and registers it in softmax_dictionary. |
| variations/activation_variations.py | Adds SquaredReLULinear and registers it in activation_dictionary. |
| train_args.py | Adds CLI choice strings and new cutoff arguments for both variants. |
| gpt_conf.py | Adds config defaults for the new cutoff parameters. |
| tests/test_linear_squared_variants.py | Adds unit tests for values, gradients, and cutoff validation. |
| explorations/linear_squared_variants_pre_norm.yaml | Adds a sweep spec to explore cutoff values for both variants. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.