Skip to content

Add linear-tail squared activation variants - #889

Open
klei22 wants to merge 1 commit into
ReaLLMASIC:masterfrom
klei22:add_relu2line_sweep
Open

Add linear-tail squared activation variants#889
klei22 wants to merge 1 commit into
ReaLLMASIC:masterfrom
klei22:add_relu2line_sweep

Conversation

@klei22

@klei22 klei22 commented Aug 14, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@klei22
klei22 requested review from gkielian and a lite review from Copilot August 14, 2026 06:53

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds C1-continuous “linear-tail” variants for squared ReLU-style activations (both as a general activation and as a ReLU2Max softmax alternative), wiring them through configuration/CLI, plus a sweep YAML and targeted tests.

Changes:

  • Introduces SquaredReLULinear and ReLU2MaxLinear with configurable positive cutoffs and linear tails matching value/slope at the cutoff.
  • Registers the new variants in the activation/softmax dictionaries and exposes new cutoff args via train_args.py and defaults via gpt_conf.py.
  • Adds pytest coverage and an exploration sweep YAML for the new variants.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
variations/softmax_variations.py Adds ReLU2MaxLinear and registers it in softmax_dictionary.
variations/activation_variations.py Adds SquaredReLULinear and registers it in activation_dictionary.
train_args.py Adds CLI choice strings and new cutoff arguments for both variants.
gpt_conf.py Adds config defaults for the new cutoff parameters.
tests/test_linear_squared_variants.py Adds unit tests for values, gradients, and cutoff validation.
explorations/linear_squared_variants_pre_norm.yaml Adds a sweep spec to explore cutoff values for both variants.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants