Skip to content

is.numeric() = FALSE for IDate, ITime#7822

Open
aitap wants to merge 4 commits into
masterfrom
IDateTime_not_really_numeric
Open

is.numeric() = FALSE for IDate, ITime#7822
aitap wants to merge 4 commits into
masterfrom
IDateTime_not_really_numeric

Conversation

@aitap

@aitap aitap commented Jul 18, 2026

Copy link
Copy Markdown
Member

Towards #7746. litedown vignettes break when they try to round() columns of type IDate/ITime as if they were numeric. What's going to break if IDate/ITime stop being numeric?

@github-actions

github-actions Bot commented Jul 18, 2026

Copy link
Copy Markdown
  • HEAD=IDateTime_not_really_numeric much slower for transform improved in #5493
    Comparison Plot

Generated via commit 0eab566

Download link for the artifact containing the test results: ↓ atime-results.zip

Task Duration
R setup and installing dependencies 3 minutes and 14 seconds
Installing different package versions 24 seconds
Running and plotting the test cases 5 minutes and 33 seconds

Unclass so that mean() -> is.numeric() doesn't warn.
@codecov

codecov Bot commented Jul 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.01%. Comparing base (94649d5) to head (0eab566).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7822   +/-   ##
=======================================
  Coverage   99.01%   99.01%           
=======================================
  Files          88       88           
  Lines       17234    17240    +6     
=======================================
+ Hits        17065    17071    +6     
  Misses        169      169           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ben-schwen

Copy link
Copy Markdown
Member

Any idea why the lintr is complaining although you didn't touch that code?

@aitap

aitap commented Jul 19, 2026 via email

Copy link
Copy Markdown
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants