Conversation
Don't overwrite list elements unless necessary. Also visit and adjust lists inside attributes.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7820 +/- ##
=======================================
Coverage 99.01% 99.02%
=======================================
Files 88 88
Lines 17234 17250 +16
=======================================
+ Hits 17065 17081 +16
Misses 169 169 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Generated via commit cf6449a Download link for the artifact containing the test results: ↓ atime-results.zip
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Rewrite
copy()in C so that instead of callingy[] <- lapply(y, reallocate)we can consider each individual list element and only callSET_VECTOR_ELTwhen necessary. This avoids the problem withxgboost's special altlist that must never be altered.Also walk the attributes of the object being copied, look for
data.tables and reallocate them. Maybe that's not necessary (copy()has been working fine without it) and can be taken out.Test 2224.3 points out an important detail: when
yis aLISTSXPpairlist,y[] <- lapply(y, reallocate)makes it into aVECSXPlist instead. It turns out we've been relying oncopy()automatically coercing pairlist columns into vector lists when constructingdata.tables. Should this become more explicit and be moved somewhere into thedata.table()constructor, leavingcopy()to just duplicate + reallocatedata.tables?Unfortunately this is hard to test without loading
xgboostor creating a different altclass.Fixes: #7456