Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #10250
Proposed Changes
This PR fixes a bug that caused keyboard shortcuts to be run multiple times when a
WidgetDivorDropDownDivwas open. Because the *Divs may live outside of the injection div, they register the global keyboard shortcut handler for their own divs, so that keyboard shortcuts still work when a dropdown or contextual menu is open. However, in the typical case where they do live in the injection div, key events would then bubble up to the main global keyboard shortcut handler and be executed again, which in the particularly case of Duplicate had obvious effects. This PR stops propagation, so that events only get run through the keyboard shortcut handler once.Test Coverage
All tests pass, and I added a test specifically for this scenario with the
WidgetDiv. In principle the problem and fix affect theDropDownDivtoo, but Duplicate is the only shortcut with a keybinding that isn't inherently idempotent and isn't also suppressed when ephemeral focus is taken.