Tests - Fix compile warnings in cpp_api unit_tests

[levxn]

Motivation

Fixes #497: Compile warnings in tests/cpp_api/unit_tests/unit_tests.cpp

Technical Details

Removed unused variable captures for rocalTensorSum, rocalTensorMin, rocalTensorMax, rocalTensorStdDev, and rocalGetLastBatchPaddedSize calls that were made purely for side effects but whose return values were never used or asserted on. Removed the unused loop index variable that was declared and incremented but never read. Explicitly discarded the hipError_t return values of the hipMalloc/hipFree calls (now [[nodiscard]] in current HIP headers) using (void) casts, since these test-only allocations were not being checked for failure.

Affected file: tests/cpp_api/unit_tests/unit_tests.cpp (lines 1190-1194, 1220, 1235, 1434-1462).

Test Plan

Built unit_tests from a clean configure with the HIP backend enabled, across all GPU targets, to confirm the warning count drops to zero:

cd tests/cpp_api/unit_tests
rm -rf CMakeCache.txt CMakeFiles
cmake -DCMAKE_CXX_COMPILER=<path-to-amdclang++> \
      -DROCM_PATH=<rocm-install-path> \
      -DHIP_DIR=<rocm-install-path>/lib/cmake/hip \
      -Dhip_DIR=<rocm-install-path>/lib/cmake/hip \
      -DBACKEND=HIP \
      .
make clean
make

Test Result

Before fix: 14 warnings generated per compile target (gfx..., host) — 4 unused-variable warnings, 8 hipMalloc/hipFree nodiscard warnings, 1 last_batch_padded_size unused-variable warning and 1 index set but unused warning.

After fix: 0 warnings generated across all three compile passes (gfx..., host); unit_tests builds and links cleanly.

[kiritigowda]

Resolves #497

[Copilot]

Pull request overview

This PR targets build cleanliness for the C++ API unit tests by removing/handling constructs that trigger compiler warnings (unused variables and ignored [[nodiscard]] HIP API results), plus a small .gitignore update for an additional build directory.

Changes:

• Stop capturing return values from several rocalTensor* reduction calls where the return was not used.
• Replace ignored hipMalloc/hipFree results with check_hip(...) to satisfy [[nodiscard]] and fail fast on HIP errors.
• Add build_verify/ to .gitignore.

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.

File	Description
tests/cpp_api/unit_tests/unit_tests.cpp	Removes/handles unused values and HIP [[nodiscard]] warnings; adds a small HIP error-check helper.
.gitignore	Ignores build_verify/ build output directory.

Suppressed comments (2)

tests/cpp_api/unit_tests/unit_tests.cpp:1244

• index is still never read: it is only incremented and not used anywhere else in this file (even under ENABLE_OPENCV), so OpenCV-enabled builds will continue to emit -Wunused-but-set-variable. Remove the unused counter entirely (or actually use it).

#if ENABLE_OPENCV
    int index = 0;
#endif

tests/cpp_api/unit_tests/unit_tests.cpp:1249

• This index++ is part of an unused counter and triggers -Wunused-but-set-variable when ENABLE_OPENCV is on. If the counter is not used (it isn't elsewhere in this file), delete the increment block.

    while (rocalGetRemainingImages(handle) >= input_batch_size) {
#if ENABLE_OPENCV
        index++;
#endif

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[sruthi0107]

For consistency with above copilot comment consider adding (void)rocalGetMatchedIndices(handle)

[rrawther]

I think this test case for sum, min and max is flawed. We need to verify the output of these functions here.

[rrawther]

Also here. Add code to verify output

[kiritigowda]

@levxn -- please address the review comments