Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a slight refactor of the BLAS multiplication strategies that makes it such that we can avoid compiling these methods for a variety of
opflags. The main point being that since BLAS takes these as a (runtime)Charinstead of compile time flag, there really is no good reason to keep this specialized, and so I simply pulled out the flag earlier in the callchain.Additionally, I converted the scalar types before the function body, again avoiding unnecessary recompilation.
Finally, I've added some precompilation instructions, since these are exercised by TensorOperations paths so this hopefully takes some of the workload from there.