Skip to content

Don't use nothing in caches #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kshyatt merged 1 commit into from
Jul 14, 2026
Merged

Don't use nothing in caches #256

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions ext/MatrixAlgebraKitEnzymeExt/MatrixAlgebraKitEnzymeExt.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ for (f, pb) in (
A_is_arg1 = !isa(A, Const) && has_equal_storage(A.val, arg.val[1])
A_is_arg2 = !isa(A, Const) && has_equal_storage(A.val, arg.val[2])
A_is_arg = A_is_arg1 || A_is_arg2
cache_arg = arg.val !== ret || A_is_arg || EnzymeRules.overwritten(config)[3] ? copy.(ret) : nothing
cache_arg = arg.val !== ret || A_is_arg || EnzymeRules.overwritten(config)[3] ? copy.(ret) : ret
dret = if EnzymeRules.needs_shadow(config) && ((TA == Nothing && TB == Nothing) || isa(arg, Const))
make_zero.(ret)
elseif EnzymeRules.needs_shadow(config)
Expand All @@ -101,7 +101,7 @@ for (f, pb) in (
A_is_arg1 = !isa(A, Const) && has_equal_storage(A.dval, arg.dval[1])
A_is_arg2 = !isa(A, Const) && has_equal_storage(A.dval, arg.dval[2])
A_is_arg = A_is_arg1 || A_is_arg2
argval = something(cache_arg, arg.val)
argval = cache_arg
if !isa(A, Const)
ΔA = A_is_arg ? make_zero(A.dval) : A.dval
$pb(ΔA, Aval, argval, darg)
Expand Down Expand Up @@ -221,7 +221,7 @@ for f! in (:svd_compact!, :svd_full!)
# if USVᴴ.val == ret, the annotation must be Duplicated or DuplicatedNoNeed
# if USVᴴ isa Const, ret may still be modified further down the call graph so we should
# copy it to protect ourselves
cache_USVᴴ = (USVᴴ.val !== ret) || EnzymeRules.overwritten(config)[3] ? copy.(ret) : nothing
cache_USVᴴ = (USVᴴ.val !== ret) || EnzymeRules.overwritten(config)[3] ? copy.(ret) : ret
# the USVᴴ may be nothing for eltypes handled by GenericLinearAlgebra
dret = if EnzymeRules.needs_shadow(config)
((TU == TS == TVᴴ == Nothing) || isa(USVᴴ, Const)) ? make_zero(ret) : USVᴴ.dval
Expand All @@ -244,7 +244,7 @@ for f! in (:svd_compact!, :svd_full!)
# A is not used in the pullback; since we have destroyed A, we insert Aval = nothing
# to trigger an error in case the pushfward is modified to directly use A
Aval = nothing
USVᴴval = something(cache_USVᴴ, USVᴴ.val)
USVᴴval = cache_USVᴴ
if !isa(A, Const)
svd_pullback!(A.dval, Aval, USVᴴval, dUSVᴴ)
end
Expand Down
Loading