Skip to content

[ge_arrow] Update to JAX and compare runtime#717

Open
xuanguang-li wants to merge 19 commits into
mainfrom
update_ge_arrow
Open

[ge_arrow] Update to JAX and compare runtime#717
xuanguang-li wants to merge 19 commits into
mainfrom
update_ge_arrow

Conversation

@xuanguang-li

@xuanguang-li xuanguang-li commented Nov 17, 2025

Copy link
Copy Markdown
Contributor

Updated the ge_arrow.md to JAX and complemented the styling consistent with the operation manual.

Key changes:

  • Rewrite the RecurCompetitive class as a NamedTuple.
  • Complete all computations inside the compute_rc_model function. Inside this function, arguments of sub-functions can be written in the same way as the definitions in the theory part.
  • Partially jitted the main computation function, and used jax.lax.fori_loop to conduct loops.
  • Fixed some typos and styling.

Update: Runtime Comparison Between JAX (GPU), JAX (CPU), and NumPy

Methodology: nearly the same as in #654

  • The JAX version uses the code in this PR, while the NumPy version uses the code in main.
  • The runtime for JAX (GPU) is measured using Google Colab T4 GPU runtime.
  • Runtime is collected using qe.timeit over 1,000 iterations.
  • Each iteration consists of solving Example 3 (solving the wealth distribution for 100 kinds of transition matrices).

Results:

  • Average runtime: JAX (CPU) > NumPy > JAX (GPU).
  • More details are shown in the attached plots.
runtime_compare_average runtime_compare_boxplot

@github-actions

github-actions Bot commented Dec 2, 2025

Copy link
Copy Markdown

@github-actions

github-actions Bot commented Dec 2, 2025

Copy link
Copy Markdown

@github-actions

github-actions Bot commented Dec 2, 2025

Copy link
Copy Markdown

@github-actions

github-actions Bot commented Dec 2, 2025

Copy link
Copy Markdown

@xuanguang-li xuanguang-li marked this pull request as ready for review December 11, 2025 00:52
 - Replace `@partial(jax.jit)` with `jax.jit` on the main function `compute_rc_model`.

- Write a function to compute example 3 and add `jax.jit` decorator.
@xuanguang-li xuanguang-li changed the title [ge_arrow] Update to JAX [ge_arrow] Update to JAX and compare runtime Feb 10, 2026
@github-actions

github-actions Bot commented Feb 11, 2026

Copy link
Copy Markdown

📖 Netlify Preview Ready!

Preview URL: https://pr-717--sunny-cactus-210e3e.netlify.app

Commit: 8c2d0d7

📚 Changed Lectures


Build Info

@xuanguang-li

Copy link
Copy Markdown
Contributor Author

Due to differences in the runtime environment, the runtime of JAX (GPU) may not be comparable to others.

Moreover, the code for both JAX and NumPy is adjusted to match each other for the test function.

Here is the runtime comparison including Numba; all runs were on the local CPU.

While JAX (CPU) accelerates the NumPy code much, Numba is about 15 times faster than JAX (CPU) for this test function.

runtime_compare_average

@xuanguang-li

Copy link
Copy Markdown
Contributor Author

A Quantitative Evaluation System for JAX Rewrites of QuantEcon Lectures

This document defines a reusable, quantitative system for deciding whether rewriting a QuantEcon lecture's code (e.g., converting NumPy → JAX) actually improves the lecture. It was designed against the first such change, lectures/ge_arrow.md (branch update_ge_arrow vs main).

The guiding principle: these are teaching lectures first and programs second. A rewrite that makes the code faster or more "modern" but harder for a learner to read, or that silently changes the numbers, is not automatically an improvement. The system therefore weights pedagogy heavily and never treats "uses JAX" as a goal in itself — JAX must earn its place on each lecture.


1. The seven dimensions

# Dimension Weight What it answers
1 Correctness & numerical fidelity 0.20 Does the new code compute the same economics, at the same precision?
2 Readability & pedagogical clarity 0.25 Can a learner follow it? Does the code mirror the math?
3 Computational efficiency (as used) 0.15 Is it faster in the regime the lecture actually runs?
4 Logic & design 0.15 Are functions natural, pure, non-repetitive, bug-free?
5 Coding style & idiom 0.10 Idiomatic Python/JAX and consistent with house style?
6 API ergonomics & reusability 0.10 How easy is the object to call, compose, and reuse?
7 Maintainability & robustness 0.05 How easy to test, debug, and safely extend later?

Weights sum to 1.0. Readability (0.25) outranks efficiency (0.15) on purpose: the audience is learners, and most lecture models are tiny. Adjust the weights per lecture family if needed (e.g. a "performance" lecture could raise dimension 3), but record any change.

Each dimension is scored 1–5 against the anchors below, then combined:

weighted_total = Σ  weight_d × score_d        (range 1–5)

Interpreting the total

Total Meaning
≥ 4.0 Clear improvement — merge.
3.0 – 3.9 Net positive but with fixable regressions — merge after addressing them.
2.5 – 2.9 Mixed / wash — improvements offset by real regressions; revisit before merging.
< 2.5 Net regression — do not merge as-is.

2. Scoring anchors + worked high/low examples

For each dimension, we give (a) the metric(s) that quantify it, (b) the 1–5 anchors, and (c) a HIGH-scoring and LOW-scoring example so reviewers agree on what "good" looks like.

Dimensions 1, 2, 3, 6 carry numeric score thresholds (a measured number maps directly to 1–5); dimensions 4, 5, 7 are structural and scored against criteria + cited evidence. The numeric thresholds were calibrated against two real, measured end points: a HIGH case (the aiyagari Bellman pattern, 25× faster as-used) and a LOW case (the full ge_arrow lecture, 45× slower as-used).

Every example below is real code already in lecture-python.myst, cited by file:line, not a hypothetical. The HIGH examples are mostly drawn from lectures the QuantEcon team has already converted well to JAX — aiyagari.md, lake_model.md — and the LOW examples from ge_arrow.md and the older class-based odu.py. (Line numbers are as of branch update_ge_arrow / main at the time of writing; search the cited symbol if they drift.)


Dimension 1 — Correctness & numerical fidelity · weight 0.20

Metrics (from check_equivalence.py):

  • all_equivalent — do all equilibrium objects (Q, R, A, V, α, ψ, J) match the original across every example economy?
  • max_abs_err — largest absolute deviation from the original numbers.
  • default dtype / precision (float32 vs float64).

Anchors (numeric — keyed to max|Δ| vs the original, as the lecture ships)

Score as-shipped max|Δ| precision
5 ≤ 1e-10 float64 preserved; any diff explained
4 ≤ 1e-8 preserved
3 logic matches under x64 (≤1e-10) but ships float32 → 1e-5…1e-3 drift, unflagged
2 1e-3 … 1e-1 on some object, or instability in edge cases
1 > 1e-1 / NaN where equality is expected — wrong economics

HIGH (5): lectures/aiyagari.md:72 opens the JAX section with

jax.config.update("jax_enable_x64", True)

so its linear solves and value iteration run in double precision — published capital/interest numbers match a NumPy reference to machine epsilon. (lectures/newton_method.md does the same.)

LOW (3, the ge_arrow case): lectures/ge_arrow.md has no such line. Under float64 the rewrite matches the original to 1.4e-14, proving the logic is identical — but as shipped it runs in float32, so example 2's printed α, ψ, J move by 1.7e-4. Correct math, quietly degraded precision. (Reproduce: run check_equivalence.py with and without JAX_ENABLE_X64=1.)


Dimension 2 — Readability & pedagogical clarity · weight 0.25

Metrics (from static_metrics.py) + reviewer reading:

  • n_prerequisite_concepts — distinct ideas a reader must already know.
  • docstring_coverage — fraction of defs with a docstring.
  • code_lines, n_defs, closure-nesting depth.
  • Math-to-code distance (judgement): does a code line look like the equation it implements?

Anchors (numeric — keyed to Δ prerequisite-concepts vs the original and to docstring coverage; both from static_metrics.py)

Score new prerequisite concepts docstring coverage &
5 +0 ≥ 0.80 code lines read like the math
4 +1–2 ≥ 0.75 still transparent
3 +3–4 0.60–0.75 readable if you know the framework
2 +5–6 < 0.60 core formula obscured by plumbing
1 +7 or more learner can't map a cell to its economics

(Use the worse of the two columns; the "&" column is the tie-breaker.)

HIGH (5): lectures/aiyagari.md:288-300 builds the Bellman right-hand side with broadcasting that visibly mirrors the math $r(a,z,a') + \beta,E,v$, and a single branchless feasibility test:

a  = jnp.reshape(a_grid, (a_size, 1, 1))     # a[i]   -> a[i, j, ip]
z  = jnp.reshape(z_grid, (1, z_size, 1))     # z[j]   -> z[i, j, ip]
ap = jnp.reshape(a_grid, (1, 1, a_size))     # ap[ip] -> ap[i, j, ip]
c = w * z + (1 + r) * a - ap
...
return jnp.where(c > 0, u(c) + β * EV, -jnp.inf)

A reader sees the budget constraint and the Bellman equation directly.

LOW (2, the ge_arrow case): lectures/ge_arrow.md:938-959 expands the one-line kernel $Q_{ij}=\beta,(y_j/y_i)^{-\gamma}P_{ij}$ into two nested jax.lax.fori_loops with q.at[j].set(...) carries:

def body_fun_i(i, Q):
    def body_fun_j(j, q):
        ratio = u_prime(c[j]) / u_prime(c[i])
        return q.at[j].set(β * ratio * P[i, j])
    q = jax.lax.fori_loop(0, n, body_fun_j, jnp.zeros((n,)))
    return Q.at[i, :].set(q)
Q = jax.lax.fori_loop(0, n, body_fun_i, jnp.zeros((n, n)))

Prerequisite concepts rise 7 → 13, docstring coverage falls 0.90 → 0.55, and the simple "ratio of marginal utilities" idea is buried under functional-update plumbing.

Also LOW (2), pre-JAX style: the Bellman operator in lectures/_static/lecture_specific/odu/odu.py:114-123 loops for i in range(N) over flattened grid points doing a fixed_quad integral per cell — the value-iteration math is hard to see through the Python scaffolding. (This is the kind of code a good JAX rewrite should improve; contrast with the aiyagari HIGH example above.)


Dimension 3 — Computational efficiency (as actually used) · weight 0.15

Crucial rule: measure efficiency in the regime the lecture runs, not a hypothetical large-scale one. For JAX that means including trace+compile time whenever the lecture hits a new shape or static_argnames value, because each of those triggers a recompile.

Metrics (from benchmark.py, cold_start.py, sweep_bench.py):

  • as-used latency (cold, lecture problem size);
  • warm/amortized latency;
  • scaling curve + the crossover n where JAX overtakes NumPy;
  • recompile cost per distinct static-arg value.

The metric that decides the score is the as-used speedup

as_used_speedup = (total NumPy wall time) / (total JAX wall time)

measured over the lecture's actual sequence of solver calls, at its actual problem sizes, in a fresh interpreter (so JAX's compiles count). >1 = JAX faster, <1 = JAX slower.

Anchors (numeric)

Score as-used speedup meaning
5 ≥ 3× materially faster as the lecture runs it
4 1.3× – 3× clearly faster
3 0.8× – 1.3× wash; JAX only wins warm / at sizes the lecture never reaches
2 < 0.8× measurably slower as used; stated goal not met, but correct & fixable
1 < 0.8× and worse (wrong/unstable, or no fix path) slower with no redemption

HIGH (5) — MEASURED. aiyagari.md is JAX on both branches (no NumPy baseline in-repo), so we benchmarked its computational pattern — the vectorised Bellman of aiyagari.md:288-300 solved by value-function iteration on a 200×7 grid, then re-solved 20× as an equilibrium loop would (scripts/bellman_bench.py, results in results/bellman_bench.json):

NumPy JAX speedup
one solve (397 VFI iters), warm 1664 ms 69 ms 24×
equilibrium loop, R=20 (as-used, incl. compile) 29.3 s 1.16 s 25×

Results agree to 1.1e-14. Large array + many fixed-shape re-solves → the one-time compile is amortised and JAX wins by 25×. *(Representative single-CPU medians; ±15% run-to-run — the decisive fact is the order of magnitude.)* as-used speedup ≈25 ≥ 3 → score 5.

LOW (2) — MEASURED. Replaying the entire ge_arrow solver sequence (all examples + the λ-sweep + finite/T=10000) once in a fresh process (scripts/as_used_total.py):

NumPy total JAX total as-used speedup
0.035 s 1.56 s 0.022× (≈45× slower)

Every economy is 2×2/3×3 and each call uses fresh static args (s0_idx, T) → a fresh compile each time (first solve 286 ms, recompile 133 ms, λ-sweep 300 ms cold). JAX would win warm at n ≳ 25 (see benchmark.py scaling), but the lecture's economics fix the size tiny. as-used 0.022 < 0.8 → score 2 (correct and fixable, so not a 1).


Dimension 4 — Logic & design · weight 0.15

Metrics: explicit_loops, repetition/DRY review, statefulness, latent bugs.

Anchors

Score Criterion
5 Pure, single-responsibility functions; no repetition; no order-dependence; no global reliance; fixes prior bugs.
4 Mostly clean; minor redundancy.
3 Works but has some duplication or awkward coupling.
2 Order-dependent mutation, duplicated computation, or reliance on globals.
1 Tangled control flow or logic that is hard to reason about / buggy.

HIGH (5): lectures/lake_model.md:216-275 declares parameters as a frozen LakeModel(NamedTuple) with defaults, then computes everything with pure jitted functions that take the model as an argument:

class LakeModel(NamedTuple):
    λ: float = 0.283; α: float = 0.013; b: float = 0.0124; d: float = 0.00822

@jax.jit
def compute_matrices(model: LakeModel):
    λ, α, b, d = model.λ, model.α, model.b, model.d
    ...

No instance is mutated, no call ordering matters, no globals. (The ge_arrow rewrite adopts this same pattern — its strongest aspect.)

LOW (2, the ge_arrow original): wealth_distribution(s0)continuation_wealths()value_functionss() must be called in that order because each mutates self; risk_free_rate recomputes sum(Q) instead of reusing PRF; pricing_kernel references the module-level P; and the public method is misspelled value_functionss. The rewrite fixing these is exactly why it scores well here.


Dimension 5 — Coding style & idiom · weight 0.10

Metrics: PEP 8 / project-style conformance, and — for JAX — whether the code uses idiomatic JAX (vectorisation, vmap, where) rather than mechanically porting Python loops.

Anchors

Score Criterion
5 Idiomatic in both languages; vectorised where natural; consistent naming.
4 Idiomatic with minor nits.
3 Correct but mixes idioms or ports loops literally where vectorisation fits.
2 Anti-idiomatic constructs that a JAX reviewer would flag.
1 Fights the framework throughout.

HIGH (5): lectures/aiyagari.md:300 uses branchless jnp.where(c > 0, u(c) + β * EV, -jnp.inf) to impose feasibility, and lectures/lake_model.md: 261 iterates a time series with jax.lax.scan (the idiomatic carry/collect primitive) instead of hand-rolled index updates.

LOW (3, the ge_arrow case): nested fori_loop scalar scatter for the pricing kernel (vectorisation was a one-liner), and jax.lax.cond(T==0, …) that traces both branches every call where T is already static and a plain Python if would do.


Dimension 6 — API ergonomics & reusability · weight 0.10

Metrics: statements_for_one_result (calls needed to obtain α, ψ, J); composability (jit/vmap-friendly?); immutability.

Anchors (numeric — keyed to statements_for_one_result, i.e. the calls a user must write to obtain α, ψ, J for one economy)

Score statements &
5 1 immutable result, trivially jit/vmap-composable
4 ≤ 2 one object + minor setup
3 3 order-independent
2 ≥ 3 ordered, side-effecting calls (wrong order → silent garbage)
1 fragile protocol, easy to misuse silently

HIGH (5): lectures/lake_model.mdmodel = LakeModel() then compute_matrices(model) / simulate_path(...); the model is an immutable argument passed to stateless functions, trivially vmap-able over parameters. The ge_arrow rewrite matches this: m = compute_rc_model(s, P, ys, s0_idx=1, T=10) returns one immutable bundle (m.Q, m.α, m.ψ, m.J, …), statements_for_one_result = 1.

LOW (2): odu.py's SearchProblem and the ge_arrow original both require build object → call mutating methods in the correct order. For ge_arrow that is wealth_distribution → continuation_wealths → value_functionss; statements_for_one_result = 4, and calling them out of order silently gives wrong/garbage results.


Dimension 7 — Maintainability & robustness · weight 0.05

Metrics: testability (pure vs stateful), debuggability (can you step through it?), and "footguns" left for future editors.

Anchors

Score Criterion
5 Pure & easily unit-tested; no silent traps; easy to extend.
4 Testable; small caveats.
3 Testable but harder to debug, or leaves a minor trap.
2 Hard to debug or carries a silent correctness trap (e.g. dtype).
1 Brittle; changes likely to break silently.

HIGH (5): lectures/aiyagari.md pairs pure jitted functions with the explicit jax.config.update("jax_enable_x64", True) at :72, so a future editor reusing the functions gets full precision by default and can unit-test each @jax.jit function in isolation.

LOW (3, the ge_arrow case): purity helps testing, but jit + static_argnames + 3-deep closures make stepping hard, and the float32 default is a silent trap for the next person who reuses the function.


3. Limitations

  • Benchmarks are CPU-only (jax.devices() == [CpuDevice]). On GPU/TPU the crossover n shifts left and JAX's warm advantage grows — but the lecture's models are still tiny, so the as-used verdict is unlikely to change.
  • Dimension scores 2/5/6 are partly judgement; the rubric anchors and the cited metrics make them auditable, not arbitrary.

@xuanguang-li

Copy link
Copy Markdown
Contributor Author

Evaluation Report — ge_arrow.md: NumPy (main) → JAX (update_ge_arrow)

Applies the evaluation system to the only code change on branch update_ge_arrow.

TL;DR — weighted score 2.95 / 5net mixed, slightly negative for this lecture

The rewrite is better software (one-call pure API, real bug fixes) but a worse lecture on the two axes that matter most here: it is harder to read and — contrary to the stated motivation — slower in every regime this lecture actually runs, while silently dropping numerical precision.

Dimension Wt Score Weighted
Correctness & numerical fidelity 0.20 3 0.60
Readability & pedagogical clarity 0.25 2 0.50
Computational efficiency (as used) 0.15 2 0.30
Logic & design 0.15 4 0.60
Coding style & idiom 0.10 3 0.30
API ergonomics & reusability 0.10 5 0.50
Maintainability & robustness 0.05 3 0.15
Total 1.00 2.95

What changed

Original (main) Rewrite (update_ge_arrow)
Library NumPy JAX (jnp, lax, jit)
Container mutable class with methods immutable NamedTuple of results
Entry point build object + 3 ordered method calls one @jit function compute_rc_model
Loops Python for (×6) jax.lax.fori_loop / lax.cond (0 Python loops)
Infinite-horizon flag T=None T=0
Notable typo value_functionss; uses global P,n,K fixes both

Evidence by dimension

1 · Correctness & numerical fidelity → 3/5

check_equivalence.py over all 11 example/initial-state combinations:

  • Under float64: every object matches, max|Δ| = 1.4e-14 → the rewrite's logic is identical. ✅
  • As the lecture actually runs (float32 default, no jax_enable_x64): ex2 deviates by 1.7e-4; several others ~1e-4. The published tables move in the 4th–5th significant figure. ❌ unflagged precision loss.

→ Correct economics, silently reduced precision. Score capped at 3.

2 · Readability & pedagogical clarity → 2/5

static_metrics.py:

metric old new
prerequisite concepts 7 13
docstring coverage 0.90 0.55
code lines (model def) 119 161
sub-definitions 10 22
Python loops a reader parses 6 0 (replaced by fori_loop closures)

The pricing kernel — mathematically just $Q_{ij}=\beta(y_j/y_i)^{-\gamma}P_{ij}$ — becomes two nested fori_loops with .at[j].set(...) carries. For a lecture whose economies are 2×2, this is pure cognitive overhead. Biggest single driver of the negative verdict (and the heaviest-weighted dimension).

3 · Computational efficiency (as used) → 2/5

This was the stated motivation, so it matters that it is not achieved here.

Headline metric — replaying the entire lecture solver sequence once in a fresh process (as_used_total.py):

NumPy total JAX total as-used speedup
0.035 s 1.56 s 0.022× — i.e. ~45× slower

Per-regime detail explaining why:

Regime (n=2 unless noted) NumPy JAX Result
First solve (cold, incl. compile) 6.2 ms 286 ms 46× slower
Recompile per new s0_idx/T 133 ms each distinct call recompiles
Warm repeat 0.032 ms 0.022 ms 1.4× faster (never used)
λ-sweep (100 pts), as run once 1.8 ms 300 ms cold 170× slower
λ-sweep warm 0.37 ms 4.8× faster (never realized)

Scaling crossover (benchmark.py): NumPy and JAX-warm are even near n≈10; JAX wins 2–6× for n = 25…200. The lecture never exceeds n=3. For calibration, the same machinery on the large, repeatedly-solved aiyagari pattern (bellman_bench.py) is 25× faster — a score-5 case. ge_arrow's 0.022× maps to score 2 (< 0.8×, but correct and fixable).

4 · Logic & design → 4/5

Genuine improvements, all verified in the diff:

  • removes order-dependent stateful methods (old required wealth_distribution → continuation_wealths → value_functionss);
  • removes reliance on module-level P, n, K (a latent bug in the original);
  • fixes the value_functionss typo;
  • de-duplicates (R no longer recomputes sum(Q)); returns one result object.

Minus one point: the pricing kernel is ported as an O(n²) scalar loop instead of a vectorised outer product.

5 · Coding style & idiom → 3/5

NamedTuple + pure function is clean. But two anti-idiomatic JAX choices: the nested-fori_loop pricing kernel (vectorisation was trivial) and jax.lax.cond(T==0, …) which traces both branches although T is already a static argument — a plain if would compile only the needed branch.

6 · API ergonomics & reusability → 5/5

statements_for_one_result: 4 → 1. compute_rc_model(s, P, ys, s0_idx=1, T=10) returns an immutable bundle; fully jit/vmap-composable. Clear win.

7 · Maintainability & robustness → 3/5

Purity aids unit testing, but jit + static_argnames + 3-deep closures hinder step-debugging, and the float32 default is a silent trap for future reuse.


Recommendation

The conversion is not yet a net improvement for this particular lecture. Two paths:

A. Keep NumPy for ge_arrow. The models are 2×2/3×3; NumPy is faster as-used, more readable, and matches the published numbers. Reserve JAX for lectures with large, repeated, fixed-shape computation.

B. If JAX is kept, fix these before re-scoring (each maps to a dimension):

  1. Vectorise the pricing kernelQ = β*(y[None,:]/y[:,None])**(-γ)*P (D2 readability, D3 efficiency, D5 idiom).
  2. Enable float64: jax.config.update("jax_enable_x64", True) so published numbers are preserved (D1, D7).
  3. Reduce recompiles: avoid making s0_idx/T static, or vectorise over s0_idx, so the lecture doesn't pay a fresh compile per call (D3).
  4. Restore docstrings on the nested helpers; replace lax.cond on a static T with a Python if (D2, D5).

Re-running run_all.py after these fixes would likely lift readability to ~3, efficiency to ~3, and the total above the 3.0 "merge after fixes" line.

@mmcky

mmcky commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Hi @xuanguang-li — thank you for these two evaluation comments, they're excellent. The framework looks really interesting: the "as-used speedup" idea in particular (fresh process, the lecture's actual problem sizes and call sequence, compile time included) is exactly the right way to decide whether JAX, Numba, or plain NumPy is the right tool for a given lecture — and it neatly explains why warm %timeit numbers were telling us the wrong story. Scoring your own PR at 2.95 and recommending against merging it as-is is great scientific practice too. 😄

I'd like to build on this with you. One idea is to turn your evaluation system into a reusable agent skill — working name /eval-py-acceleration — that can run the full evaluation on any lecture conversion (old vs new implementation): the float32/float64 equivalence check, the static readability metrics, the as-used benchmark replay, and finally a scored report in the format of your comment above.

That would let us apply this consistently across the lecture series as we review conversion PRs, and I think it could grow into the start of a broader benchmarking project for the QuantEcon lectures. Once the skill has settled we'll distill the rubric into the QuantEcon manual alongside the existing JAX conversion style guide, so the thresholds and tooling stay in sync.

Would you be up for building this together? A great first step would be gathering the scripts you reference (check_equivalence.py, static_metrics.py, benchmark.py, cold_start.py, sweep_bench.py, as_used_total.py, bellman_bench.py, run_all.py) into one place — a zip attached to an email, or a gist all work. From there we can iterate together on generalizing them beyond ge_arrow and wrapping them in the skill.

@mmcky

mmcky commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

On this PR itself: given your own evaluation I'd suggest we hold off on merging for now. One path worth considering is keeping the structure of your rewrite — the NamedTuple, the pure one-call API, and the real bug fixes (order-dependent methods, the module-level P, the value_functionss typo) — but implemented in plain NumPy, which would capture the dimensions where your rewrite clearly won without the compile-time and precision costs.

And once the skill exists, this PR would make a perfect first test case for it.

@xuanguang-li

Copy link
Copy Markdown
Contributor Author

Thanks for your comments, @mmcky.

It's a fascinating idea to build the evaluation system into a skill. I'll package the test scripts soon and send them by email. From the related PRs, I've started to see the broader picture of the evaluation project, and I'm glad to be able to contribute to such a useful initiative.

One path worth considering is keeping the structure of your rewrite — the NamedTuple, the pure one-call API, and the real bug fixes (order-dependent methods, the module-level P, the value_functionss typo) — but implemented in plain NumPy.

Yes, I think that's a reasonable approach given the evaluation result. With only minor changes to the coding logic while preserving the NumPy structure, it should be possible to provide a clearer and more explicit implementation.

@jstac

jstac commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

🤖 Status note for a future session — from a maintainer investigation on 2026-07-08 into why open-PR previews 404. Context only, not instructions.

Netlify preview: https://pr-717--sunny-cactus-210e3e.netlify.app/ currently returns 404.

Why previews are down (repo-wide findings)

1. This branch is stale — 174 commits behind main. A preview build compiles the whole site from this branch. This branch's lectures/house_auction.md still has unpinned !pip install prettytable, which now breaks on a wcwidth incompatibility. main fixed this on 2026-06-28 by pinning prettytable<3.18 (#939). This alone fails any rebuild of this branch until it's updated to main.

2. The arviz failure was a red herring — do NOT pin arviz or rewrite plotting. A 2026-07-07 rebuild also failed in ar1_bayes/ar1_turningpts with an arviz_plots figsize ValueError. That was a transient bug in an intermediate arviz-plots 1.x release, already fixed in arviz 1.2.0. Verified locally on a clean latest-stack venv: the real az.plot_trace(trace) cell (pymc + numpyro InferenceData) runs green. The lectures use only 1.x-compatible arviz APIs (plot_trace, summary, from_numpyro, compare).

Note on recent timeline activity

This PR was close/reopened on 2026-07-07 by a maintainer session purely to trigger a rebuild test — not a content change. That rebuild failed on the stale-branch issue above. Apologies for the notification churn.

Recommended first step for this PR

Update this branch to main (merge or rebase — pulls in #939 plus ~174 other commits), then let CI rebuild. On today's latest libraries the site builds clean, so the preview should return. house_auction is the known blocker; updating also picks up other since-merged fixes — rebuild and address any remaining per-lecture failures. Verify with:

curl -sI https://pr-717--sunny-cactus-210e3e.netlify.app/ge_arrow.html

This PR touches: ge_arrow.md. Last CI build: failure@2026-07-07. Branch: 174 commits behind main as of 2026-07-08.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Development

Successfully merging this pull request may close these issues.

3 participants