[ak_aiyagari] Fix inconsistent household reference (hh → household)#706
[ak_aiyagari] Fix inconsistent household reference (hh → household)#706sudayuga wants to merge 2 commits into
hh → household)#706Conversation
This PR resolves a naming inconsistency and potential bug across several functions where a global variable hh was referenced instead of the household argument passed into the function. This issue affects several key components of the model's implementation, including find_ss, popu_dist, compute_aggregates, and others.
|
many thanks @sudayuga ! @HumphreyYang , could you please review? |
|
🤖 Status note for a future session — from a maintainer investigation on 2026-07-08 into why open-PR previews 404. Context only, not instructions. Netlify preview: none — and there never was one. This PR is from a fork ( Why previews are down (repo-wide findings)1. This branch is stale — 126 commits behind 2. The arviz failure was a red herring — do NOT pin arviz or rewrite plotting. A 2026-07-07 rebuild also failed in Recommended first step for this PRUpdate the fork branch to This PR touches: |
Summary
Several functions incorrectly referenced a global variable
hhinstead of using thehouseholdargument passed to them.This caused silent inconsistency and potential runtime failure if
hhis not defined in the global scope.Fix
hh.*references withhousehold.*backwards_opt,popu_dist,compute_aggregates,and
solve_backwardsto use the injectedhouseholdobject