Skip to content

[hoist_failure] Clean up the code and correct minor errors#656

Draft
HumphreyYang wants to merge 3 commits into
mainfrom
clean_hoist
Draft

[hoist_failure] Clean up the code and correct minor errors#656
HumphreyYang wants to merge 3 commits into
mainfrom
clean_hoist

Conversation

@HumphreyYang

Copy link
Copy Markdown
Member

This PR cleans up the code and correct minor errors and typos across the lecture.

It also improves the printing and smooth some of the sentences.

@github-actions

Copy link
Copy Markdown

📖 Netlify Preview Ready!

Preview URL: https://pr-656--sunny-cactus-210e3e.netlify.app (a9df52c)

📚 Changed Lecture Pages: hoist_failure

@github-actions

Copy link
Copy Markdown

📖 Netlify Preview Ready!

Preview URL: https://pr-656--sunny-cactus-210e3e.netlify.app (174da1f)

📚 Changed Lecture Pages: hoist_failure

@jstac

jstac commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

🤖 Status note for a future session — from a maintainer investigation on 2026-07-08 into why open-PR previews 404. Context only, not instructions.

Netlify preview: https://pr-656--sunny-cactus-210e3e.netlify.app/ currently returns 404.

Why previews are down (repo-wide findings)

1. This branch is stale — 166 commits behind main. A preview build compiles the whole site from this branch. This branch's lectures/house_auction.md still has unpinned !pip install prettytable, which now breaks on a wcwidth incompatibility. main fixed this on 2026-06-28 by pinning prettytable<3.18 (#939). This alone fails any rebuild of this branch until it's updated to main.

2. The arviz failure was a red herring — do NOT pin arviz or rewrite plotting. A 2026-07-07 rebuild also failed in ar1_bayes/ar1_turningpts with an arviz_plots figsize ValueError. That was a transient bug in an intermediate arviz-plots 1.x release, already fixed in arviz 1.2.0. Verified locally on a clean latest-stack venv: the real az.plot_trace(trace) cell (pymc + numpyro InferenceData) runs green. The lectures use only 1.x-compatible arviz APIs (plot_trace, summary, from_numpyro, compare).

Recommended first step for this PR

Update this branch to main (merge or rebase — pulls in #939 plus ~166 other commits), then let CI rebuild. On today's latest libraries the site builds clean, so the preview should return. house_auction is the known blocker; updating also picks up other since-merged fixes — rebuild and address any remaining per-lecture failures. Verify with:

curl -sI https://pr-656--sunny-cactus-210e3e.netlify.app/hoist_failure.html

This PR touches: hoist_failure.md. Last CI build: success@2025-11-14. Branch: 166 commits behind main as of 2026-07-08.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants