publish: fix hyphenated page-url output reference (env URL)#356
Merged
Conversation
`steps.deployment.outputs.page-url` is parsed as subtraction in GitHub Actions expressions (the hyphen), so environment.url wouldn't evaluate. Use index syntax `outputs['page-url']`. Cosmetic (env URL display only). Caught by Copilot review of QuantEcon/lecture-datascience.myst#280. Part of QuantEcon/meta#282. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
✅ Deploy Preview for lustrous-melomakarona-3ee73e ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes the GitHub Actions expression used to populate the GitHub Pages deployment environment.url so it correctly reads a hyphenated action output (page-url) using index syntax rather than dot notation (which treats page-url as subtraction).
Changes:
- Update
environment.urlto usesteps.deployment.outputs['page-url']so the deployment UI link resolves correctly.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Small fix to the
github-pagesdeploymentenvironment.urlinpublish.yml. The value referenced the action'spage-urloutput with dot notation:In GitHub Actions expressions a hyphen in dot notation is parsed as subtraction (
pageminusurl), so this doesn't resolve to the output. The fix uses index syntax:quantecon/actions/publish-gh-pagesdoes expose an output namedpage-url(hyphenated), so index syntax is required to read it.Impact
Cosmetic only —
environment.urlsets the clickable link shown on the deployment in the repo's Environments/Deployments UI. Publishing and the live site are unaffected (this line has been deploying fine as-is). This just makes that convenience link resolve correctly.Caught by Copilot review of the datascience migration (QuantEcon/lecture-datascience.myst#280); the same line came from the shared reference used across the family, so this applies the fix to the already-merged repos too. Part of QuantEcon/meta#282.
🤖 Generated with Claude Code