Skip to content

fix(section-secret-manager-highlight): remove buggy Firefox animation#2793

Merged
rmnbrd merged 1 commit into
stagingfrom
codex/fix-secret-manager-firefox-animation
Jul 3, 2026
Merged

fix(section-secret-manager-highlight): remove buggy Firefox animation#2793
rmnbrd merged 1 commit into
stagingfrom
codex/fix-secret-manager-firefox-animation

Conversation

@RemiBonnet

Copy link
Copy Markdown
Member

Summary

Issue:

Screenshots / Recordings

Testing

  • Changes tested locally in the relevant Console's pages and Storybooks
  • yarn test or yarn test -u (if you need to regenerate snapshots)
  • yarn format
  • yarn lint

PR Checklist

  • I followed naming, styling, and TypeScript rules (see .cursor/rules)
  • I performed a self-review (diff inspected, dead code removed)
  • I titled the PR using Conventional Commits with a scope when possible (e.g. feat(service): add new Terraform service) - required for semantic-release
  • I only kept necessary comments, written in English (watch for useless AI comments)
  • I involved a designer to validate UI changes if I am not a designer
  • I covered new business logic with tests (unit)
  • I confirmed CI is green (Codecov red can be accepted)
  • I reviewed and executed locally any AI-assisted code

@RemiBonnet RemiBonnet marked this pull request as ready for review July 2, 2026 16:04
@RemiBonnet RemiBonnet changed the title fix(section-secret-manager-highlight): remove Firefox animation fix(section-secret-manager-highlight): remove buggy Firefox animation Jul 2, 2026
@codecov

codecov Bot commented Jul 2, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 37.50000% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 47.17%. Comparing base (752065d) to head (80ac694).
⚠️ Report is 1 commits behind head on staging.

Files with missing lines Patch % Lines
...ger-highlight/section-secret-manager-highlight.tsx 0.00% 4 Missing ⚠️
libs/shared/util-js/src/index.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           staging    #2793      +/-   ##
===========================================
- Coverage    47.44%   47.17%   -0.27%     
===========================================
  Files         1267     1200      -67     
  Lines        26812    25644    -1168     
  Branches      7913     7621     -292     
===========================================
- Hits         12721    12098     -623     
+ Misses       11892    11461     -431     
+ Partials      2199     2085     -114     
Flag Coverage Δ
unittests 47.17% <37.50%> (-0.27%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@RemiBonnet RemiBonnet force-pushed the codex/fix-secret-manager-firefox-animation branch 2 times, most recently from 8bdfdf1 to 5d0b04d Compare July 2, 2026 17:42
@RemiBonnet RemiBonnet force-pushed the codex/fix-secret-manager-firefox-animation branch from 5d0b04d to 80ac694 Compare July 2, 2026 17:53
@rmnbrd rmnbrd merged commit 042b859 into staging Jul 3, 2026
12 checks passed
@rmnbrd rmnbrd deleted the codex/fix-secret-manager-firefox-animation branch July 3, 2026 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants