refactor(graphql): extract subscription wire protocol#869
Merged
Conversation
Move the message vocabulary, frame serialization, and incoming-frame parsing out of GraphqlService into a SubscriptionProtocol seam with a LegacySubscriptionProtocol implementation. No wire or behavior change; prepares for the graphql-ws protocol migration (Qminder/server#28325). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
KonradPaluch
approved these changes
Jul 23, 2026
KonradPaluch
left a comment
KonradPaluch
left a comment
Contributor
There was a problem hiding this comment.
looks good!
left one suggestion
…ce.ts Co-authored-by: Konrad Paluch <konradpaluch97@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracts the subscription wire protocol (message vocabulary, frame serialization, and incoming-frame parsing) out of
GraphqlServicebehind aSubscriptionProtocolseam with zero wire/behavior change, as step 1 of the graphql-ws migration.