Add condition evaluation mappings#2
Draft
Quantumyilmaz wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TESCondition::IsTrue,BGSConditionForm::IsTrue, and the recoveredConditionCheckParamsconstructorTESCondition::IsTrueABI, including its display-failure output parameterBGSConditionForm::IsTrueConditionCheckParamssize andBGSConditionFormmember offsetsRE notes
TESConditionout parameter is retained because callers pass a real byte-local address, even though the current callee does not appear to write itBGSConditionFormhelper uses the exact five-argument registered-native ABI and is documented as game-thread-onlyNiPointer; inventing ownership semantics would risk unbalanced reference countsConditionCheckParams + 0x68remains conservatively unnamedValidation
clang-formatand whitespace checksRE/Starfield.hIntegration check
All four QTR draft branches cherry-pick together cleanly, and the combined tree passes full CommonLibSF MSVC debug and release builds.