Skip to content

chore: fix test warning#519

Merged
allenporter merged 2 commits into
Python-roborock:mainfrom
cdce8p-forks:fix-test-warning
Oct 5, 2025
Merged

chore: fix test warning#519
allenporter merged 2 commits into
Python-roborock:mainfrom
cdce8p-forks:fix-test-warning

Conversation

@cdce8p

@cdce8p cdce8p commented Oct 5, 2025

Copy link
Copy Markdown
Contributor
tests/devices/test_v1_channel.py::test_v1_channel_command_encoding_validation
  /.../python-roborock/roborock/devices/v1_channel.py:233:
      RuntimeWarning: coroutine 'AsyncMockMixin._execute_mock_call' was never awaited
    self._local_channel.close()

Close is a normal function, not async.

def close(self) -> None:
"""Disconnect from the device."""
if self._transport:
self._transport.close()
else:
_LOGGER.warning("Close called but transport is already None")
self._transport = None
self._is_connected = False

@cdce8p

cdce8p commented Oct 5, 2025

Copy link
Copy Markdown
Contributor Author

/CC @allenporter

Lash-L
Lash-L previously requested changes Oct 5, 2025

@Lash-L Lash-L left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests seem to be failing

@allenporter allenporter merged commit df6c674 into Python-roborock:main Oct 5, 2025
6 checks passed
@allenporter

Copy link
Copy Markdown
Contributor

Thank you!

@cdce8p cdce8p deleted the fix-test-warning branch October 5, 2025 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants