ci: update / clean up wasm build#6166
Conversation
Merging this PR will degrade performance by 26.2%
Warning Please fix the performance issues or acknowledge them on CodSpeed. Performance Changes
Tip Investigate this regression by commenting Comparing 
|
| # wasi sdk sets CC variables which break Python's configure script | ||
| # (it also sets WASI_SDK_PATH even without `add-to-path`, which is sufficient) | ||
| add-to-path: false | ||
| - run: python -m pip install --upgrade pip && pip install nox[uv] |
There was a problem hiding this comment.
Why do we use pip specifically? It seems that when I ran some mini benchmarks, even using actions with the uv installation plus uv pip install was faster
There was a problem hiding this comment.
Yes this is a copy-paste, I have been generally changing actions to just use uvx nox and dropping this step entirely.
There was a problem hiding this comment.
Updated in eb6b6b7 (there are probably other jobs in ci.yml which still could move to uv)
|
Looks like this succeeded, so whether it was a bad cache or something fixed by this refactoring, I guess we move forwards? |
2 participants
This is an attempt to make the wasm build error reproducible locally. I moved its logic into
noxfile.pyandMakefileto match the emscripten build.It works fine for me when running in this fashion, let's test CI.
I updated the
emscriptenbuild a little at the same time (and shared the python download logic between them).