Y069: Flag NoReturn on import - #552
Open
srittau wants to merge 4 commits into
Open
Conversation
Closes: #551
This comment has been minimized.
This comment has been minimized.
Member
Author
|
See python/typeshed#16079 for the companion PR. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Collaborator
|
Given that the place where we now flag this lint is non-overlapping with where we flagged it before, it might be better to use a new code and retire the existing one. Otherwise people migrating might have a hard time updating their configs. (I'm thinking partly of Ruff which uses the same codes.) |
|
⚠ Flake8 diff showing the effect of this PR on typeshed: > ./stdlib/typing_extensions.pyi:33:1: Y069 Use "typing_extensions.Never" instead of "typing.NoReturn" |
Member
Author
This is the re-export of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #551