feat: extend ApiModule to support unified Proton Suite (Mail, Drive, Pass, VPN)#119
feat: extend ApiModule to support unified Proton Suite (Mail, Drive, Pass, VPN)#119HardikYerne wants to merge 1 commit into
Conversation
|
Hi Proton team! 👋 I noticed that installing Proton VPN alongside Mail, Drive and Pass This PR extends ApiModule.cs to register all Proton app API clients Happy to make any changes based on your feedback! Thanks, |
HardikYerne
changed the title
|
Hi team! This PR is ready for review. |
|
Yy |
About pull requestsPull requests let you propose, review, and merge code changes. Pull requests are proposals to merge code changes into a project. A pull request is GitHub's foundational collaboration feature, letting you discuss and review changes before merging them. This helps teams work together, catch issues early, and maintain code quality. Working with pull requestsThe Conversation tab of a pull request displays a description of the changes, a timeline of events, and comments and reviews from collaborators. This central hub lets you track the discussion and progress of the proposed changes. The Commits tab shows all commits made to the pull request branch in chronological order. This helps you understand the development history and see how the changes evolved over time. The Checks tab displays the status of any automated tests, builds, or other continuous integration workflows that run when you push commits. These checks help ensure your changes meet quality standards before merging. The Files changed tab shows the differences between the proposed changes and the existing code, making it easy to see what will change when the pull request merges. The Merge status of a pull request can be viewed directly in the header from anywhere in the pull request page. Click to open the details so you can quickly identify blockers, missing approvals, and get your pull request ready to merge. Draft pull requestsWhen you create a pull request, you can choose to make it a draft pull request. Draft pull requests cannot be merged, and code owners are not automatically requested to review them. This is useful when you want to share work-in-progress without formally requesting reviews. When you're ready to get feedback on your pull request, you can mark your draft pull request as ready for review. Marking a pull request as ready for review will request reviews from any code owners. You can convert a pull request to a draft at any time. See Changing the stage of a pull request. Pull request refs and merge branchesWhen you open a pull request, GitHub creates up to two temporary, read-only Git references for it:
The merge branch automatically updates when the head branch changes. To fetch it locally: git fetch origin refs/pull/PULL_REQUEST_NUMBER/merge
git checkout FETCH_HEADReplace For information about how GitHub Actions uses the merge branch, see Events that trigger workflows. Differences between commits on compare and pull request pagesThe compare and pull request pages use different methods to calculate the diff for changed files:
Further reading |
1 similar comment
About pull requestsPull requests let you propose, review, and merge code changes. Pull requests are proposals to merge code changes into a project. A pull request is GitHub's foundational collaboration feature, letting you discuss and review changes before merging them. This helps teams work together, catch issues early, and maintain code quality. Working with pull requestsThe Conversation tab of a pull request displays a description of the changes, a timeline of events, and comments and reviews from collaborators. This central hub lets you track the discussion and progress of the proposed changes. The Commits tab shows all commits made to the pull request branch in chronological order. This helps you understand the development history and see how the changes evolved over time. The Checks tab displays the status of any automated tests, builds, or other continuous integration workflows that run when you push commits. These checks help ensure your changes meet quality standards before merging. The Files changed tab shows the differences between the proposed changes and the existing code, making it easy to see what will change when the pull request merges. The Merge status of a pull request can be viewed directly in the header from anywhere in the pull request page. Click to open the details so you can quickly identify blockers, missing approvals, and get your pull request ready to merge. Draft pull requestsWhen you create a pull request, you can choose to make it a draft pull request. Draft pull requests cannot be merged, and code owners are not automatically requested to review them. This is useful when you want to share work-in-progress without formally requesting reviews. When you're ready to get feedback on your pull request, you can mark your draft pull request as ready for review. Marking a pull request as ready for review will request reviews from any code owners. You can convert a pull request to a draft at any time. See Changing the stage of a pull request. Pull request refs and merge branchesWhen you open a pull request, GitHub creates up to two temporary, read-only Git references for it:
The merge branch automatically updates when the head branch changes. To fetch it locally: git fetch origin refs/pull/PULL_REQUEST_NUMBER/merge
git checkout FETCH_HEADReplace For information about how GitHub Actions uses the merge branch, see Events that trigger workflows. Differences between commits on compare and pull request pagesThe compare and pull request pages use different methods to calculate the diff for changed files:
Further reading |
2 participants
Problem
When installing Proton VPN on Windows, the installer registers multiple separate
entries in Programs & Features / Apps & Features:
This is confusing for users who expect a single application. It makes uninstallation
unclear and gives the impression that the install is broken or incomplete.
Expected Behavior
All core VPN components (TAP adapter, Split Tunnel driver, service) should be bundled
under a single installer entry. Users should only see "Proton VPN" in their installed
apps list, and uninstalling it should cleanly remove all related components.
Suggested Solution
only one top-level product entry
product, without creating separate Programs & Features entries
Why This Matters
Environment