Skip to content

refactor(planner): hoist subpopulation_count placeholder into a shared constant #534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
milindsrivastava1997 merged 1 commit into from
Jul 22, 2026
+9 −7
Merged

refactor(planner): hoist subpopulation_count placeholder into a shared constant #534

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions asap-planner-rs/src/optimizer/constants.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,3 +33,9 @@ pub const INGEST_MEM_WEIGHT: f64 = 1e-9;
pub const INGEST_CPU_WEIGHT: f64 = 1.0;
pub const QUERY_MEM_WEIGHT: f64 = 1e-9;
pub const QUERY_CPU_WEIGHT: f64 = 1.0;

/// Subpopulation count: 1 if subpopulation_aware else the distinct label-group
/// count for this config. The label-group count isn't profiled yet (needs
/// Prometheus series-count data) — use 1 as a placeholder; both branches
/// collapse to the same value until that lands.
pub const SUBPOPULATION_COUNT: f64 = 1.0;
10 changes: 3 additions & 7 deletions asap-planner-rs/src/optimizer/cost_model.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ use super::candidate_gen::CandidateConfig;
use super::constants::{
EXACT_QUERY_CPU_SECS, INGEST_CPU_WEIGHT, INGEST_MEM_WEIGHT, INSERT_CPU_SECS,
MEM_BYTES_PER_INSTANCE, MERGE_CPU_SECS, QUERY_CPU_SECS, QUERY_CPU_WEIGHT, QUERY_MEM_WEIGHT,
SUBTRACT_CPU_SECS,
SUBPOPULATION_COUNT, SUBTRACT_CPU_SECS,
};
use super::sketch_properties::sketch_properties;
use super::solution::{QueryMethod, AQE};
Expand Down Expand Up @@ -75,11 +75,7 @@ pub fn ingest_cost(
return 0.0; // EXACT: no streaming config deployed.
};

// Subpopulation count: 1 if subpopulation_aware else the distinct
// label-group count for this config. The label-group count isn't profiled
// yet (needs Prometheus series-count data) — use 1 as a placeholder; both
// branches collapse to the same value until that lands.
let subpopulation_count = 1.0_f64;
let subpopulation_count = SUBPOPULATION_COUNT;

// Defensive floor: slide_interval_ms is a plain u64 on a widely-shared struct;
// guard against div-by-zero producing `inf` and poisoning cost comparisons.
Expand Down Expand Up @@ -112,7 +108,7 @@ pub fn query_cost(
};

// Subpopulation count; see ingest_cost comment.
let subpopulation_count = 1.0_f64;
let subpopulation_count = SUBPOPULATION_COUNT;
let props = sketch_properties(agg_config.aggregation_type);

let (cpu, mem) = match &candidate.query_method {
Expand Down
Loading