Skip to content

fix(planner): fix small bug in planner retention count for aggregates (num_aggregates_to_retain) #428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
milindsrivastava1997 merged 1 commit into from
Jun 23, 2026
Merged

fix(planner): fix small bug in planner retention count for aggregates (num_aggregates_to_retain) #428

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions asap-planner-rs/src/optimizer/translator.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,11 +53,12 @@ pub fn retention_count_for_assignment(query_method: &QueryMethod) -> u64 {
match query_method {
QueryMethod::Direct => 1,
QueryMethod::Merge { num_windows } => *num_windows,
// Subtract needs 2 prefix checkpoints per query but we retain
// ceil(range_a/W) checkpoints total to cover the full lookback.
// The exact value comes from the config's window parameters; use 1
// as a placeholder until Phase 3 wires this up properly.
QueryMethod::Subtract => 1,
// Subtract combines exactly 2 prefix-sum checkpoints per query
// (current cumulative, and the one from range_a ago), regardless of
// how many checkpoints the engine retains to make that pair available
// (see candidate_gen.rs's n_windows, a separate concept: the deployed
// AggregationConfig's retention depth).
QueryMethod::Subtract => 2,
QueryMethod::Exact => 0,
}
}
Expand Down
Loading