feat(sql-parser): Support half-open time >= A AND time < B in SQL WHERE clause for benchmark parity #409
Merged
milindsrivastava1997 merged 2 commits intoJun 22, 2026
Conversation
milindsrivastava1997
approved these changes
Jun 22, 2026
milindsrivastava1997
deleted the
408-feat-sql-parser-support-left-close-and-right-open
branch
June 22, 2026 15:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code Changes
1.
sqlpattern_parser.rs(core logic)time >= … AND time < …in addition to the existingBETWEENsupport.TimeInfo { start, duration }model — no changes toTimeInfo, engine timestamp math, store logic, or pattern matching.>=(lower bound) +<(upper bound)>/<=combinations (treated as unmatched queries)A <= time AND B > time)get_timestamp_from_between_highlowto returnNoneon unrecognized time expressions instead of panicking, preventing engine/planner crashes on malformed input.2. Tests
sqlparser_test.rsBETWEEN, reversed order, column-on-right forms,NOW()-relative expressions, matcher classification, template matching, and rejection casesquery_equivalence_tests.rsBETWEENexecution context and rejection of>/<=combinationssql_integration.rsBETWEENplans and that>/<=combinations returnSqlParseerrorsWhat Did Not Change
BETWEENbehaviorBehavior Matrix
time BETWEEN A AND B>= A AND <= B) — may differ from ASAPtime >= A AND time < B[A, B)— aligned with ASAPtime > A AND time <= B