Skip to content

feat: add side-by-side market comparison modal and update events section#526

Merged
greatest0fallt1me merged 1 commit into
Predictify-org:mainfrom
dolaoluwa574-source:feature/compare-markets
Jul 24, 2026
Merged

feat: add side-by-side market comparison modal and update events section#526
greatest0fallt1me merged 1 commit into
Predictify-org:mainfrom
dolaoluwa574-source:feature/compare-markets

Conversation

@dolaoluwa574-source

Copy link
Copy Markdown
Contributor

Closes #466

What changed

  • Added a new modal component at CompareMarketsModal.tsx with:
    • side-by-side market details
    • responsive layout for mobile and desktop
    • keyboard support for closing and clearing
    • accessible dialog semantics and focus-friendly controls
  • Wired the new modal into the events experience via events-section.tsx.
  • Added focused regression coverage in compare-overlay.test.tsx.
  • Documented the visible UI change in README.md.

Verification

  • Editor diagnostics report no errors in the new modal and wiring files.
  • I could not run the Jest/lint commands in this session because terminal execution was skipped, so the commands to run locally are:
    • pnpm exec jest --runInBand components/market/__tests__/compare-overlay.test.tsx
    • pnpm lint

No API contract changes were introduced; this is a UI/UX enhancement only.

Made changes.

@vercel

vercel Bot commented Jul 24, 2026

Copy link
Copy Markdown

@dolaoluwa574-source is attempting to deploy a commit to the Jagadeesh B's projects Team on Vercel.

A member of the Team first needs to authorize it.

@drips-wave

drips-wave Bot commented Jul 24, 2026

Copy link
Copy Markdown

@dolaoluwa574-source Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@greatest0fallt1me
greatest0fallt1me merged commit d5ae46f into Predictify-org:main Jul 24, 2026
1 check failed
@greatest0fallt1me

Copy link
Copy Markdown
Contributor

Merged into main via admin resolver (-X theirs).

@grantfox-oss grantfox-oss Bot mentioned this pull request Jul 24, 2026
4 tasks
@greatest0fallt1me

Copy link
Copy Markdown
Contributor

Nice work — merging. Thanks for the tests too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add cross-market compare modal

2 participants