Polish market countdown timer with reduced motion fallback#521
Open
GiftedGiftB wants to merge 2 commits into
Open
Conversation
|
@GiftedGiftB is attempting to deploy a commit to the Jagadeesh B's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@GiftedGiftB Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closed #366
Description
This PR addresses issue #366 by polishing the market countdown timer's behavior when a user prefers reduced motion. It fixes an accessibility bug and testing issue where the static label under reduced motion resulted in duplicate elements and double-announcements for screen readers.
Type of Change
Related Issues
Closes #366
Changes Made
Files Modified
components/disputes/shared/CountdownTimer.tsx(Lines 210-216)Key Changes
sr-onlyaria-live region in theCountdownTimercomponent so it is omitted whenprefersReducedMotionis true.CountdownTimer.test.tsxwhich expected a single accessible label to be rendered.Testing
Test Coverage
Screenshots/Videos
Minimum screenshots for UI/design PRs
Before
(Omitted - DOM structure issue causing duplicate accessibility reads)
After
(Omitted - Corrected DOM structure successfully limits to a single text node under reduced-motion)
Pre-submission Checklist
Code Quality
Functionality
Documentation
Security & Accessibility
Breaking Changes
Breaking Changes:
Migration Steps:
Additional Notes
Dependencies
Performance Impact
Browser/Device Support
Labels
bugfixui/uxfrontendReviewers