feat: deprecated entrypoints registry#883
Open
Emmanuel5vohd wants to merge 1 commit into
Open
Conversation
Adds a persistent, on-chain registry for deprecated contract entrypoints.
## New: contracts/predictify-hybrid/src/deprecated.rs
- DeprecatedEntry {entrypoint, replacement, since, note} contracttype
- DeprecatedRegistry with admin-gated register/remove and permissionless
get_entry / list_entries / entry_count / is_deprecated reads
- MAX_REGISTRY_ENTRIES = 64 capacity guard (→ Error::RegistryFull 528)
- record_call() helper wraps emit_deprecated for use in entrypoint bodies
- Emits depr_reg / depr_rem events for off-chain indexers
## Modified: err.rs
- Added RegistryFull = 528
## Modified: lib.rs
- mod deprecated + pub use deprecated::{DeprecatedEntry, DeprecatedRegistry, MAX_REGISTRY_ENTRIES}
- #[cfg(test)] mod deprecated_tests
- 6 new contract entrypoints: register_deprecated, remove_deprecated,
get_deprecated_entry, list_deprecated_entries, deprecated_entry_count,
is_deprecated
- verify_result and resolve_market updated to call DeprecatedRegistry::record_call
## New: src/deprecated_tests.rs
- 20 focused unit tests covering: register (happy-path, idempotency,
capacity, auth guard), remove (present/absent, auth guard), read
paths (get_entry, list, count, is_deprecated), event emission,
re-registration after removal
## Modified: docs/DEPRECATION_POLICY.md, contracts/predictify-hybrid/README.md
- Full registry API docs, event table, capacity limits, usage examples
Closes Predictify-org#847
|
@Emmanuel5vohd Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a persistent, on-chain registry for deprecated contract entrypoints.
New: contracts/predictify-hybrid/src/deprecated.rs
Modified: err.rs
Modified: lib.rs
New: src/deprecated_tests.rs
Modified: docs/DEPRECATION_POLICY.md, contracts/predictify-hybrid/README.md
Closes #847
Pull Request Description
📋 Basic Information
Type of Change
Please select the type of change this PR introduces:
Related Issues
Closes #(issue number)
Fixes #(issue number)
Related to #(issue number)
Priority Level
📝 Detailed Description
What does this PR do?
Why is this change needed?
How was this tested?
Alternative Solutions Considered
🏗️ Smart Contract Specific
Contract Changes
Please check all that apply:
Oracle Integration
Market Resolution Logic
Security Considerations
🧪 Testing
Test Coverage
Test Results
Manual Testing Steps
📚 Documentation
Documentation Updates
Breaking Changes
Breaking Changes:
Migration Guide:
🔍 Code Quality
Code Review Checklist
Performance Impact
Security Review
🚀 Deployment & Integration
Deployment Notes
Integration Points
📊 Impact Assessment
User Impact
Business Impact
✅ Final Checklist
Pre-Submission
Review Readiness
📸 Screenshots (if applicable)
🔗 Additional Resources
💬 Notes for Reviewers
Please pay special attention to:
Questions for reviewers:
Thank you for your contribution to Predictify! 🚀
Closes #847