Add syntax highlighting for dispose blocks and fix test assertions - #226
Draft
Andy Jordan (andyleejordan) with Copilot wants to merge 3 commits into
Draft
Add syntax highlighting for dispose blocks and fix test assertions#226Andy Jordan (andyleejordan) with Copilot wants to merge 3 commits into
dispose blocks and fix test assertions#226Andy Jordan (andyleejordan) with Copilot wants to merge 3 commits into
Conversation
Add dispose{} named block keyword to language files.
Yay, editor highlighting!
Co-authored-by: andyleejordan <2226434+andyleejordan@users.noreply.github.com>
Co-authored-by: andyleejordan <2226434+andyleejordan@users.noreply.github.com>
Copilot
AI
changed the title
Fix failing tests and add support for Dispose function Dispose{} dispose block (IDisposable)
Add syntax highlighting for Aug 27, 2026
dispose blocks and fix test assertions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The initial implementation for
disposeblock syntax highlighting failed CI due to misaligned token assertions in the test suite and an outdated compiled JSON grammar file.Changes
disposeto the named block control keyword regex inPowerShellSyntax.tmLanguage, properly integrating it alongside the newly addedcleanblock.spec/testfiles/syntax_test_Function.ps1by adding a space before the brace (Dispose {). This ensures theatom-grammar-testcolumn pointers correctly align with the parsed token boundaries.powershell.tmLanguage.jsonfile so the tests run against the updated regex patterns.Example