fix: create scoped staging S3 secret from activation creds - #1023
Draft
EDsCODE wants to merge 1 commit into
Draft
Conversation
Test Impact PlanDeterministic summary of how this PR changes tests, CI runners, and coverage-risk signals. Summary
Signals
Coverage risk: likely reduced Warnings
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The primary DuckLake secret may use the cache proxy's HTTP transport. Delta staging reads need a more-specific direct HTTPS secret. Creating that secret through DuckDB's credential chain fails on multi-tenant workers because their per-tenant credentials are brokered into the activation payload rather than exposed through a provider that DuckDB can discover.
Duckgres already has the correct temporary credential bundle, so it can create both secrets without another credential lookup.
Compatibility
The additional secret is only created for AWS S3 configurations with explicit credentials. Credential-chain deployments and custom S3-compatible endpoints keep their existing behavior.
Testing
just ci