Skip to content

fix(spaces): hold sidebar peek open while space Filter menu is open #3972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
dmarticus wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −1
Draft

fix(spaces): hold sidebar peek open while space Filter menu is open #3972

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion packages/ui/src/features/canvas/components/ChannelSidebar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ import { useChannelItems } from "@posthog/ui/features/canvas/hooks/useChannelIte
import { useCommandCenterStore } from "@posthog/ui/features/command-center/commandCenterStore";
import { useFeatureFlag } from "@posthog/ui/features/feature-flags/useFeatureFlag";
import { SidebarItem } from "@posthog/ui/features/sidebar/components/SidebarItem";
import { useHoldSidebarPeek } from "@posthog/ui/features/sidebar/useHoldSidebarPeek";
import { useTaskContextMenu } from "@posthog/ui/features/tasks/useTaskContextMenu";
import { useRenameTask } from "@posthog/ui/features/tasks/useTaskMutations";
import { useTasks } from "@posthog/ui/features/tasks/useTasks";
Expand Down Expand Up @@ -84,6 +85,10 @@ function RecentSectionHeader({
onStatusChange: (value: TaskRunStatus | null) => void;
filtersActive: boolean;
}) {
// Hold the sidebar's hover-peek open while the Filter menu is open, so a
// pointer moving toward the menu can't collapse the peeked panel and strand
// the dropdown's portal anchor (matches TasksHeader/ProjectSwitcher).
const handleFilterOpenChange = useHoldSidebarPeek();
return (
<>
<div className="flex items-center gap-0.5 pr-1">
Expand All @@ -99,7 +104,7 @@ function RecentSectionHeader({
>
<MagnifyingGlass size={12} />
</button>
<DropdownMenu>
<DropdownMenu onOpenChange={handleFilterOpenChange}>
<DropdownMenuTrigger
render={
<button
Expand Down
Loading