Skip to content

feat: local mods support/tweak - #748

Open
rozwader wants to merge 1 commit into
mainfrom
feat/support-for-local-mods
Open

feat: local mods support/tweak#748
rozwader wants to merge 1 commit into
mainfrom
feat/support-for-local-mods

Conversation

@rozwader

Copy link
Copy Markdown
Collaborator

Description

Added support for local mods info parsed from their manifests.

Added converting local file mods to mods handled by modrinth/curseforge, so now if a local mod is recognized to be from modrinth or curseforge (First Modrinth, then curseforge), it can be updated if a new version gets uploaded

  • because of it, if a mod is recognized, it doesn't sit in the "local" tab inside mods list view. Only when mod is not recognized it sits there.

Added "first match" for Modrinth and CurseForge, before even if Modrinth recognized a mod, it was being sent to the CurseForge. Now when Modrinth recognizes a mod it stops and a request to the CurseForge is not sent.

Added batch requests for drag and drop mods, e.g user wants to drop 20 new mods inside the launcher. Before it sent 40 requests (Modrinth and CurseForge), now it sends one request to a new endpoint that allows sending batches of mods instead of one request per each mod.

How it works:
-> User drops a mod/s
-> One or all of them are being sent to the Modrinth
-> If MDR recognizes all of them, they are being assigned as a MDR mod (end of the chain).
-> If MDR doesn't recognize every mod, the rest are being sent to the CF fingerprint endpoint
-> If CF doesn't recognize every mod or any, it's going to be saved as a local mod

Related Issue(s)

#676

How to test

First Feature

  1. Add a mod and if it turns out to be local, it will have more info than before (Image, Author/s, Title, Description).
    e.g
image

Second Feature

  1. Try adding a mod by drag and drop or by "+ Add Content"
  2. Look it up in the "All" section inside mods tab in a given cluster
  3. If it has Modrinth or CurseForge badge, it has been recognized and now will be updated when a new version is present
  4. If it says local file, it wasn't recognized by any of the providers. It's not being updated

Third Feature
If you find a way to check network traffic then you'll see.

Fourth Feature
Again, network traffic.

Documentation

No

…local mods to modrinth/curseforge handled mods if found
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

1 participant