feat: added memory allocation presets to minecraft and cluster settings - #747
Open
rozwader wants to merge 1 commit into
Open
feat: added memory allocation presets to minecraft and cluster settings#747rozwader wants to merge 1 commit into
rozwader wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added memory allocation presets dropdown inside settings/minecraft and cluster settings
Also added validation for the memory allocation input (User cannot enter more MB of ram than his computer contains).
The cluster memory setting has priority over minecraft settings (if someone choosed 4GB inside minecraft settings, but choosed 8GB inside cluster settings, game will start with 8GB of memory).
Related Issue(s)
#573
How to test
Minecraft settings
Cluster settings
Documentation
No