feat: added MB4/MB5 and Esc navigation globaly - #742
Open
rozwader wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added support for MB4 and MB5 as a navigation thru navigation history (globally)
Added support for Esc navigation globally
Changed big chunk of buttons to work on
on_pressinstead ofon_all_pressbecause MB4/MB5 would also fire the event, but with the new navigation system it would fire up the event and immediately go back to the previous view. So now only LMB works for clicksPopups like modals, dropdowns or text inputs have priority, so clicking Esc on dropdown doesn't send you to the previous view, but only closes up the list. Clicking MB4/MB5 while priority views are visible doesn't work. Clicking Esc on text input firstly unfocuses the input and on the second click leaves the view.
Clicking Esc on the last route in history makes you go back to the route you were in previously
Related Issue(s)
#565
#566
How to test
Documentation
No