Skip to content

feat: added MB4/MB5 and Esc navigation globaly - #742

Open
rozwader wants to merge 1 commit into
mainfrom
feat/back-navigation-support-cluster-settings
Open

feat: added MB4/MB5 and Esc navigation globaly#742
rozwader wants to merge 1 commit into
mainfrom
feat/back-navigation-support-cluster-settings

Conversation

@rozwader

Copy link
Copy Markdown
Collaborator

Description

Added support for MB4 and MB5 as a navigation thru navigation history (globally)
Added support for Esc navigation globally

Changed big chunk of buttons to work on on_press instead of on_all_press because MB4/MB5 would also fire the event, but with the new navigation system it would fire up the event and immediately go back to the previous view. So now only LMB works for clicks

Popups like modals, dropdowns or text inputs have priority, so clicking Esc on dropdown doesn't send you to the previous view, but only closes up the list. Clicking MB4/MB5 while priority views are visible doesn't work. Clicking Esc on text input firstly unfocuses the input and on the second click leaves the view.

Clicking Esc on the last route in history makes you go back to the route you were in previously

Related Issue(s)

#565
#566

How to test

  1. Play in the OneClient app with navigating and then going back/goind forward with MB4/MB5
  2. Also play with Esc. When I was testing, different routes and views always behaved correctly (Not always going straigth to home, but for example in the mod browser clicking on mod info and clicking Esc goes back again to the mod browser, not home)

Documentation

No

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In progress

Development

Successfully merging this pull request may close these issues.

2 participants