Skip to content

feat: microsoft jdk provider - #729

Open
rozwader wants to merge 5 commits into
mainfrom
feat/minecraft-sdk-provider
Open

feat: microsoft jdk provider#729
rozwader wants to merge 5 commits into
mainfrom
feat/minecraft-sdk-provider

Conversation

@rozwader

Copy link
Copy Markdown
Collaborator

Description

(just named the branch incorrectly)

  1. Added Microsoft OpenJDK as a vendor for installing java runtimes.
  2. Changed default provider/vendor to be Microsoft.
  3. Added a modal, asking user to install/migrate to Microsoft JDK instead of the previous one he used.
  4. Added a pop up as a toast, that informs user he can't delete JDK that is pinned to any cluster (before there was an error in the database and nothing happend on the UI).
  5. Added prioritization of Microsoft OpenJDK at cluster launch.

Related Issue(s)

#707

How to test

First Feature

  1. Go into java settings in OneClient
  2. Click "Install Manager"
  3. By default microsoft jdk list will be visible
  4. All the versions can be downloaded and work (tested on windows 10)

Second Feature

  • Whenever there is a java runtime installation, it will always try to install Microsoft OpenJDK if it's not specified to install from other vendor.

Third Feature

  1. Open up OneClient, if you have an automatic jdk on the last played cluster and you don't own Microsoft JDK it will start installing automatically.
  2. Open up OneClient, if you have some jdk pinned to the cluster and it's not Microsoft OpenJDK, then it will prompt you to install Microsoft JDK designated for this version.
  • when every installation completes, it will change the java runtime selection to Automatic if it's not already there.

Fourth Feature

  1. Pin some jdk to a cluster, (anything other than automatic) you won't be able to delete it. Toast will inform you to what cluster it is pinned

Fifth Feature

  1. If you have automatic on a cluster you're currently launching, it will always try to use Microsoft OpenJDK.

Documentation

No

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In progress

Development

Successfully merging this pull request may close these issues.

2 participants