Skip to content

Add Johto safari zone encounters#1557

Open
Machine-Maker wants to merge 2 commits into
PokeAPI:masterfrom
Machine-Maker:fix/johto-safari-zone
Open

Add Johto safari zone encounters#1557
Machine-Maker wants to merge 2 commits into
PokeAPI:masterfrom
Machine-Maker:fix/johto-safari-zone

Conversation

@Machine-Maker

Copy link
Copy Markdown
Contributor

Change description

Adds gen iv Johto safari zone encounters
Closes #1522

AI coding assistance disclosure

Claude helped

Contributor check list

  • I have written a description of the contribution and explained its motivation.
  • I have written tests for my code changes (if applicable).
  • I have read and understood the AI Assisted Contribution guidelines.
  • I will own this change in production, and I am prepared to fix any bugs caused by my code change.

@Machine-Maker Machine-Maker force-pushed the fix/johto-safari-zone branch from fca7f9e to a2673a4 Compare June 13, 2026 18:13
@jemarq04

jemarq04 commented Jun 16, 2026

Copy link
Copy Markdown
Member

Can you provide more of a description to what you're adding? What I'm reading on Bulbapedia does not match what you're adding here.

For example, Fearow isn't available in johto-safari-zone-peak unless there are 5 Forest block objects placed in it, according to Bulbapedia. However, this PR just adds a johto-safari-displaced with prose "Displaced by block-based encounter". This doesn't seem very clear to me (and I'm not sure what is even meant by "displaced").

Some encounters require multiple types of blocks, so maybe something more reasonable would be a set of encounter conditions - one for each type of block object that would need to be placed. Then a set of relevant condition values would be added (e.g. a johto-safari-forest-block condition with a johto-safari-forest-block-5 condition value for Fearow's, or something like this). I think this would make things a lot clearer as to how we would encounter these pokemon in the area

Also.. "Claude helped" is not much of a description for how you used AI to aid this PR. You've added a lot of helpful encounters we've missed, so thank you for that, but please try to be descriptive in these descriptions so we know what we're reviewing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Johto Safari Zone is missing block-based encounters

2 participants