Add oras surfing and fishing encounters (Part 1)#1542
Conversation
ConnorMolz
changed the title
|
Hi I completely missed this PR, sorry for the late reply. I'll try to see if the additions round up in the next days |
Hi, All fine was busy last days... |
… + fix some jotho double ids
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds new encounter data and normalizes encounter method records in the v2 CSV dataset.
Changes:
- Appends new encounter rows for additional location areas/versions.
- Introduces new encounter slots tied to newly added methods/slot distributions.
- Fixes missing IDs in encounter methods and adds prose for new methods.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| data/v2/csv/encounters.csv | Adds new encounter rows referencing newly-added slot IDs. |
| data/v2/csv/encounter_slots.csv | Adds new encounter slot definitions to support the new encounters/methods. |
| data/v2/csv/encounter_methods.csv | Fills in missing IDs and adds a new encounter method. |
| data/v2/csv/encounter_method_prose.csv | Adds new prose rows for honey-tree and poke-nav-surfing. |
| 54,hidden-grotto,54 | ||
| 55,honey-tree,54 No newline at end of file | ||
| 55,honey-tree,54 | ||
| 56,poke-nav-surfing,55 No newline at end of file |
| 55,9,Slathering a Honey Tree with Honey and waiting for a Pokémon to appear. No newline at end of file | ||
| 55,9,Slathering a Honey Tree with Honey and waiting for a Pokémon to appear. | ||
| 56,9,Surfing and using the PokéNav Plus in Pokémon Omega Ruby and Alpha Sapphire | ||
| 56,6,Surfen und das Poké-Multi-Navi nutzen in Pokémon Omega Rubin und Alpha Saphire No newline at end of file |
|
@Naramsim I dont know why there still a Merge conflict, I fixed it local... |
|
Sorry for the Ping got it solved localy |
Change description
I am adding the surfing and fishing encounters from ORAS to the project.
I will add in this PR Route 101 to 109, Oldale Town, Petalburg City, Rustboro City, Dewford Town and Slateport City
AI coding assistance disclosure
I used only the inline assistance of VS-Code (not sure if its AI).
Contributor check list