OctreeSearch: also support leaf types without getPointIndicesVector()… - #6467
Open
mvieth wants to merge 2 commits into
Open
OctreeSearch: also support leaf types without getPointIndicesVector()…#6467mvieth wants to merge 2 commits into
mvieth wants to merge 2 commits into
Conversation
… function Use getPointIndicesVector() if the leaf type has it, otherwise fall back to the previous leaf.getPointIndices() (which likely copies indices).
mvieth
added
module: octree
changelog: fix
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates OctreePointCloudSearch::getNeighborsWithinRadiusRecursive() to support leaf container types that do not provide getPointIndicesVector(), restoring compatibility with OctreeContainerBase-compliant custom leaf containers (per issue #6466).
Changes:
- Introduces a small SFINAE-based helper to detect whether a leaf type has
getPointIndicesVector(). - Uses
getPointIndicesVector()when available, otherwise falls back toleaf.getPointIndices(...)(copying indices as needed). - Updates the radius-neighbor iteration to use the new helper instead of calling
getPointIndicesVector()unconditionally.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… function
Use getPointIndicesVector() if the leaf type has it, otherwise fall back to the previous leaf.getPointIndices() (which likely copies indices).
Fixes #6466