-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
WIP: Split common/include/pcl/impl/point_types.hpp
#6367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sumir0
wants to merge
33
commits into
PointCloudLibrary:master
Choose a base branch
from
sumir0:feature/split-impl-point-types
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
30bf21a
Add header for feature types
sumir0 05615a3
Move `MomentInvariants` to feature types header
sumir0 1c7be54
Move `PrincipalRadiiRSD` to feature types header
sumir0 552dfee
Move `Boundary` to feature types header
sumir0 d2c0b87
Move `PrincipalCurvatures` to feature types header
sumir0 b75a002
Move `descriptorSize` to separate header
sumir0 8c45d0d
Move `SHOT352` to feature types header
sumir0 26bfc70
Move `SHOT1344` to feature types header
sumir0 07b1e3a
Include memory header in feature types
sumir0 e48a8ab
Move `ReferenceFrame` to feature types header
sumir0 c32fc1b
Optimize point includes in `SHOT` headers
sumir0 52412f2
Move `ShapeContext1980` to feature types header
sumir0 aa4af65
Move `UniqueShapeContext1960` to feature types header
sumir0 272f252
Move `PFHSignature125` to feature types header
sumir0 1afcfd9
Move `PFHRGBSignature250` to feature types header
sumir0 cc8dc4e
Move `PPFSignature` to feature types header
sumir0 fc2c5d3
Move `CPPFSignature` to feature types header
sumir0 7402294
Move `PPFRGBSignature` to feature types header
sumir0 72467bc
Move `NormalBasedSignature12` to feature types header
sumir0 14118f2
Move `FPFHSignature33` to feature types header
sumir0 ce5bc24
Move `VFHSignature308` to feature types header
sumir0 65a9a0c
Move `GRSDSignature21` to feature types header
sumir0 d7b2ae0
Move `ESFSignature640` to feature types header
sumir0 503da3d
Move `GASDSignature512` to feature types header
sumir0 f85c25b
Move `GASDSignature984` to feature types header
sumir0 3b25887
Move `GASDSignature7992` to feature types header
sumir0 aa66ad2
Move `GFPFHSignature16` to feature types header
sumir0 7d74481
Move `BRISKSignature512` to feature types header
sumir0 c41ee63
Add missing point types include in GASD test
sumir0 83334e2
Move `Narf36` to feature types header
sumir0 bbedeb0
Move `Histogram<N>` to feature types header
sumir0 c1a58b9
Remove `detail::traits` empty namespace from point types
sumir0 29ff8c0
Disable MSVC 4201 warning in `feature_types.h`
sumir0 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| /* | ||
| * SPDX-License-Identifier: BSD-3-Clause | ||
| * * Point Cloud Library (PCL) - www.pointclouds.org | ||
| * Copyright (c) 2026-, Open Perception Inc. | ||
| * * All rights reserved | ||
| */ | ||
|
|
||
| #pragma once | ||
|
|
||
| namespace pcl | ||
| { | ||
| namespace detail | ||
| { | ||
| namespace traits | ||
| { | ||
| template<typename FeaturePointT> struct descriptorSize {}; | ||
|
|
||
|
|
||
| template<typename FeaturePointT> | ||
| static constexpr int descriptorSize_v = descriptorSize<FeaturePointT>::value; | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,163 @@ | ||
| /* | ||
| * SPDX-License-Identifier: BSD-3-Clause | ||
| * * Point Cloud Library (PCL) - www.pointclouds.org | ||
| * Copyright (c) 2026-, Open Perception Inc. | ||
| * * All rights reserved | ||
| */ | ||
|
|
||
| #pragma once | ||
|
|
||
|
|
||
| /** | ||
| * \file pcl/feature_types.h | ||
| * Defines all the PCL implemented PointT feature type structures | ||
| * \ingroup common | ||
| */ | ||
|
|
||
| // Allow nameless structs/unions | ||
| #if defined _MSC_VER | ||
| #pragma warning(push) | ||
| #pragma warning(disable: 4201) | ||
| #endif | ||
|
|
||
| /** @{*/ | ||
| namespace pcl | ||
| { | ||
| /** \brief Members: float j1, j2, j3 | ||
| * \ingroup common | ||
| */ | ||
| struct MomentInvariants; | ||
|
|
||
| /** \brief Members: float r_min, r_max | ||
| * \ingroup common | ||
| */ | ||
| struct PrincipalRadiiRSD; | ||
|
|
||
| /** \brief Members: std::uint8_t boundary_point | ||
| * \ingroup common | ||
| */ | ||
| struct Boundary; | ||
|
|
||
| /** \brief Members: float principal_curvature[3], pc1, pc2 | ||
| * \ingroup common | ||
| */ | ||
| struct PrincipalCurvatures; | ||
|
|
||
| /** \brief Members: float descriptor[352], rf[9] | ||
| * \ingroup common | ||
| */ | ||
| struct SHOT352; | ||
|
|
||
| /** \brief Members: float descriptor[1344], rf[9] | ||
| * \ingroup common | ||
| */ | ||
| struct SHOT1344; | ||
|
|
||
| /** \brief Members: Axis x_axis, y_axis, z_axis | ||
| * \ingroup common | ||
| */ | ||
| struct ReferenceFrame; | ||
|
|
||
| /** \brief Members: float descriptor[1980], rf[9] | ||
| * \ingroup common | ||
| */ | ||
| struct ShapeContext1980; | ||
|
|
||
| /** \brief Members: float descriptor[1960], rf[9] | ||
| * \ingroup common | ||
| */ | ||
| struct UniqueShapeContext1960; | ||
|
|
||
| /** \brief Members: float pfh[125] | ||
| * \ingroup common | ||
| */ | ||
| struct PFHSignature125; | ||
|
|
||
| /** \brief Members: float pfhrgb[250] | ||
| * \ingroup common | ||
| */ | ||
| struct PFHRGBSignature250; | ||
|
|
||
| /** \brief Members: float f1, f2, f3, f4, alpha_m | ||
| * \ingroup common | ||
| */ | ||
| struct PPFSignature; | ||
|
|
||
| /** \brief Members: float f1, f2, f3, f4, f5, f6, f7, f8, f9, f10, alpha_m | ||
| * \ingroup common | ||
| */ | ||
| struct CPPFSignature; | ||
|
|
||
| /** \brief Members: float f1, f2, f3, f4, r_ratio, g_ratio, b_ratio, alpha_m | ||
| * \ingroup common | ||
| */ | ||
| struct PPFRGBSignature; | ||
|
|
||
| /** \brief Members: float values[12] | ||
| * \ingroup common | ||
| */ | ||
| struct NormalBasedSignature12; | ||
|
|
||
| /** \brief Members: float fpfh[33] | ||
| * \ingroup common | ||
| */ | ||
| struct FPFHSignature33; | ||
|
|
||
| /** \brief Members: float vfh[308] | ||
| * \ingroup common | ||
| */ | ||
| struct VFHSignature308; | ||
|
|
||
| /** \brief Members: float grsd[21] | ||
| * \ingroup common | ||
| */ | ||
| struct GRSDSignature21; | ||
|
|
||
| /** \brief Members: float esf[640] | ||
| * \ingroup common | ||
| */ | ||
| struct ESFSignature640; | ||
|
|
||
| /** \brief Members: float gasd[512] | ||
| * \ingroup common | ||
| */ | ||
| struct GASDSignature512; | ||
|
|
||
| /** \brief Members: float gasd[984] | ||
| * \ingroup common | ||
| */ | ||
| struct GASDSignature984; | ||
|
|
||
| /** \brief Members: float gasd[7992] | ||
| * \ingroup common | ||
| */ | ||
| struct GASDSignature7992; | ||
|
|
||
| /** \brief Members: float histogram[16] | ||
| * \ingroup common | ||
| */ | ||
| struct GFPFHSignature16; | ||
|
|
||
| /** \brief Members: float scale; float orientation; std::uint8_t descriptor[64] | ||
| * \ingroup common | ||
| */ | ||
| struct BRISKSignature512; | ||
|
|
||
| /** \brief Members: float x, y, z, roll, pitch, yaw; float descriptor[36] | ||
| * \ingroup common | ||
| */ | ||
| struct Narf36; | ||
|
|
||
| /** \brief Members: float histogram[N] | ||
| * \ingroup common | ||
| */ | ||
| template<int N> | ||
| struct Histogram; | ||
| } // namespace pcl | ||
| /** @} */ | ||
|
|
||
| #include <pcl/impl/feature_types.hpp> | ||
|
|
||
| #if defined _MSC_VER | ||
| #pragma warning(pop) | ||
| #endif |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there an advantage in having this in a separate file instead of in feature_types.hpp?