:test: test(compare): kill the surviving EffectChallenge intervention mutant (TEST-02) - #79
Merged
Merged
Conversation
… mutant (TEST-02) The 2026-08-18 audit (TEST-02) demonstrated by mutation that deleting `|| e == aggregate.EffectChallenge` from `isStricterInterventionEffect` left `go test ./internal/compare/...` AND `task dogfood-comparison` green: a regression that stops classifying challenge-effect deltas as stricter interventions could merge through every wired gate. Confirmed independently on this lane's base before writing anything (both tiers exit 0 with the term deleted). Unit tier (REQ-AUD2-S04-01): new `classify_intervention_test.go` pins a baseline-APPROVE / candidate-adds-`challenge` delta to `stricter-intervention-added`, plus the predicate pair directly and the already-carried-challenge negative that exercises `interventionFindingsByIdentity`. The fixture is built so the four higher-priority detectors (D-117 ladder) stay silent, otherwise the assertion never reaches the mutated predicate. Corpus tier (REQ-AUD2-S04-03): new `challenge-intervention-added` case under `examples/comparison/promotion-gates/` — a `/retentionMs` shrink, a candidate-only `retention-ack` challenge rule scoped to that pointer, its D-121 bundle pin, an `explicitly-accepted-deltas` allowlist row, and the recorded ComparisonRecord. The four pre-existing records regenerate byte-identical. Mutation re-performed with the tests in place (REQ-AUD2-S04-02 / REQ-AUD2-S04-04): `go test ./internal/compare/...` fails on TestClassifyStricterInterventionAddedChallengeEffect and TestInterventionEffectPredicates; `task dogfood-comparison` fails with `exit status 6` fail-closed on the new case. The predicate itself is byte-unchanged. `isMissedInterventionEffect` deliberately still excludes `challenge` and is pinned as such — out of scope, not a bug. REQ-AUD2-S04-01, REQ-AUD2-S04-02, REQ-AUD2-S04-03, REQ-AUD2-S04-04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AUD2-S04 (TEST-02). Adds a regression test and comparison-corpus case that kill the surviving
EffectChallengeintervention mutant ininternal/compare/classify_intervention.go.Tests-and-corpus only —
internal/compare/classify_intervention.gois byte-unchanged vsmain.internal/compare/classify_intervention_test.go— new coverage for the challenge-intervention pathexamples/comparison/promotion-gates/**— newchallenge-intervention-addedcase, candidate + suite + expected recordCHANGELOG.md— regenerated by the integrator (implementers are fenced from it)Independent review: APPROVE, no P0/P1, no merge conditions.
Gate: cold
task check(aftergo clean -testcache) exits 0 on the rebased head, includingchangelog-verify.Rebased onto
origin/main(f886381); opened from an integrate branch because the CHANGELOG amend rewrote the publishedlane/aud2-s04head and force-push is not authorized.