Skip to content

Fix false warning that Download::GitHub is not being used and should. - #434

Open
mohawk2 wants to merge 2 commits into
mainfrom
calm-negotiate
Open

Fix false warning that Download::GitHub is not being used and should.#434
mohawk2 wants to merge 2 commits into
mainfrom
calm-negotiate

Conversation

@mohawk2

@mohawk2 mohawk2 commented Jul 26, 2026

Copy link
Copy Markdown
Contributor

@zmughal

zmughal commented Jul 27, 2026

Copy link
Copy Markdown
Member

Tested this against the Alien-xz alienfile and it works.

The has_requires seems reasonable as a new public API method given that other plugins use it. But we may want exact matching instead of substring or regex (which gives you exact anyway with anchors). Or do:

$pattern_qr = ref $pattern eq 'Regexp' ? $pattern : qr/\Q$pattern\E/

The reason I would feel more comfortable with exact matching is that, here in the Alien-Build core, we can be specific about which plugin we are looking for.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Download::Negotiate warning false positive when using Download::GitHub plugin

2 participants