Fix Raise Spider count not granting Attack Speed - #10043
Open
LocalIdentity wants to merge 2 commits into
Open
Conversation
The change to have a count for minions for Companionship was also the function that was setting the limit output for all minion types. Cause Spiders have the MinionsAreUndamageable skilltype, they were being excluded I got rid of that check as its no longer needed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10041
Description of the problem being solved:
The change to have a count for minions for Companionship was also the function that was setting the limit output for all minion types.
Cause Spiders have the MinionsAreUndamageable skilltype, they were being excluded
I got rid of that check as its no longer needed
Link to a build that showcases this PR:
https://maxroll.gg/poe/pob/7sr2av0t
Before screenshot:
After screenshot: