Skip to content

Fix advanced paste - #10039

Open
LocalIdentity wants to merge 12 commits into
devfrom
fix_advanced-paste
Open

Fix advanced paste#10039
LocalIdentity wants to merge 12 commits into
devfrom
fix_advanced-paste

Conversation

@LocalIdentity

@LocalIdentity LocalIdentity commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Fixes #10016, Fixes #10017, Fixes #10008

Description of the problem being solved:

Fixes a number of issues with advanced copy paste

  • Crucible trees not importing
  • Ignore stat requirements on items that are added via gems
  • Fix the mod ordering on import to use stat order instead of mod order
  • Fix catalysts recrafting an item on import and showing incorrect values
  • Fix modifier magnitude values changing on import (e.g. Simplex)
  • Parse legacy rolls for some stats e.g. 40(10)
  • Ignore some flask lines
  • Use finer precision for timeless jewels as 3 digits was not enough to cover 8000 values
  • Editing a slider on a legacy mod now only changes that mod instead of changing all the other legacy mods on the item to use current values
  • Fix Dark Monarch and Replica Dragonfang
  • Ordering of unique and fractured mods
  • Memory strands
  • Import of mods with 2 damage values e.g. Adds 2 to 4 phys damage

Steps taken to verify a working solution:

  • Test a number of different build
  • Import many different catalysts and other items
  • Add tests for many of the above scenarios
Rarity: Unique
Soul Catcher
Quartz Flask
--------
Quality: +20% (augmented)
Lasts 7.20 (augmented) Seconds
Consumes 30 of 60 Charges on use
Currently has 59 Charges
+10% chance to Suppress Spell Damage
(40% of Damage from Suppressed Hits and Ailments they inflict is prevented)
Phasing
(While you have Phasing, your movement is not blocked by Enemies)
--------
Requirements:
Level: 27
--------
Item Level: 79
--------
Used when Charges reach full (enchant)
--------
{ Unique Modifier — Mana }
Cannot gain Mana during effect
{ Unique Modifier }
93(60-80)% increased Damage with Vaal Skills during effect
{ Unique Modifier }
Non-Aura Vaal Skills require 25% reduced Souls Per Use during Effect
{ Unique Modifier }
Vaal Skills used during effect have 40(10)% reduced Soul Gain Prevention Duration
--------
Freedom is for the privileged, even in death.

This item can be transformed on the Altar of Sacrifice along with Vial of the Ghost
--------
Right click to drink. Can only hold charges while in belt. Refills as you kill monsters.
Item Class: Amulets
Rarity: Rare
Grim Collar
Simplex Amulet
--------
Quality (Critical Modifiers): +20% (augmented)
--------
Requirements:
Level: 64
--------
Item Level: 87
--------
Allocates Force of Darkness (enchant)
--------
{ Implicit Modifier }
-2 Prefix Modifiers allowed
-1 Suffix Modifier allowed
Implicit Modifiers Cannot Be Changed
100% increased Explicit Modifier magnitudes
--------
{ Prefix Modifier "The Elder's" (Tier: 1) — Damage, Chaos  — 100% Increased }
Gain 13(3-5)% of Non-Chaos Damage as extra Chaos Damage
{ Suffix Modifier "of Destruction" (Tier: 1) — Damage, Critical  — 120% Increased }
+70(35-38)% to Global Critical Strike Multiplier
{ Suffix Modifier "of Amassment" — Drop  — 100% Increased }
20(17-20)% increased Quantity of Items found
--------
Mirrored
--------
Split
--------
Shaper Item
Elder Item
Item Class: Bows
Rarity: Rare
Brimstone Arch
Synthesised Citadel Bow
--------
Bow
Quality: +20% (augmented)
Physical Damage: 36-144
Critical Strike Chance: 3.00% (augmented)
Attacks per Second: 1.25
--------
Requirements:
Level: 82
Str: 126 (unmet)
Dex: 185 (unmet)
Int: 129 (unmet)
--------
Sockets: W-W-W-W-W-W 
--------
Item Level: 83
--------
Quality does not increase Physical Damage (enchant)
Grants 1% increased Area of Effect per 4% Quality (enchant)
--------
{ Implicit Modifier — Damage, Caster }
Spells have a 18(16-18)% chance to deal Double Damage
{ Implicit Modifier — Gem }
+6(4-6)% to Quality of Socketed Gems
{ Implicit Modifier — Gem }
+1 to Level of Socketed Support Gems
--------
{ Prefix Modifier "Paragon's" (Tier: 1) — Gem }
+1 to Level of Socketed Gems
{ Master Crafted Prefix Modifier "Upgraded" — Gem }
+2 to Level of Socketed Support Gems
{ Master Crafted Prefix Modifier "Upgraded" — Damage, Elemental, Cold, Chaos }
Gain 16(14-16)% of Cold Damage as Extra Chaos Damage
{ Suffix Modifier "of the Underground" (Tier: 1) }
Non-Aura Vaal Skills require 40% reduced Souls Per Use
{ Suffix Modifier "of the Order" (Tier: 1) — Damage }
14(12-14)% chance to deal Double Damage
{ Suffix Modifier "of Destruction" (Tier: 1) — Damage, Critical }
+38(35-38)% to Global Critical Strike Multiplier
--------
Mirrored
--------
{ Allocated Crucible Passive Skill (Tier: 1) }
+1 to Level of Socketed Dexterity Gems
{ Allocated Crucible Passive Skill (Tier: 3) }
-3% to Critical Strike Chance
+100% to Global Critical Strike Multiplier
{ Allocated Crucible Passive Skill (Tier: 2) }
20% reduced Flask Charges gained
Flasks applied to you have 15% increased Effect
{ Allocated Crucible Passive Skill (Tier: 1) }
Rampage
(You gain Rampage bonuses for Killing multiple Enemies in quick succession)
--------
Synthesised Item
Item Class: Jewels
Rarity: Unique
Elegant Hubris
Timeless Jewel
--------
Limited to: 1 Historic
Radius: Large
--------
Item Level: 86
--------
{ Unique Modifier }
Commissioned 103300(2000-160000) coins to commemorate Cadiro(Cadiro-Victario)
Passives in radius are Conquered by the Eternal Empire
(Conquered Passive Skills cannot be modified by other Jewels)
Historic
--------
They believed themselves better than the past, but that confidence brought about nightmare.
--------
Place into an allocated Jewel Socket on the Passive Skill Tree. Right click to remove from the Socket.

Before screenshot:

image image image image

After screenshot:

image image image image

LocalIdentity added 5 commits July 27, 2026 10:12
Timeless jewels have a range of 8k possible values so having it use only 100 incremements meant that it would round the final seed to whole numbers in large increments #10017
Flasks had a bunch of extra lines that weren't needed
@LocalIdentity LocalIdentity added the bug: behaviour Behavioral differences label Jul 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug: behaviour Behavioral differences

Projects

None yet

1 participant