Improve stat search with pseudo stats and word order ignore - #10036
Open
vaisest wants to merge 3 commits into
Open
Improve stat search with pseudo stats and word order ignore#10036vaisest wants to merge 3 commits into
vaisest wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
This adds pseudo stats to the trader filter dropdowns, adds an option to
SearchHostto ignore word order (so that e.g. "pseudo caster matches "caster modifiers (pseudo)") which matches what~does on the trade site. I also fixed a bug with the highlight being off if the label had escapesThe search order change could also be applied to other places, but I imagine there might be small performance problems since matching from left to right is faster.
I also updated trade site data since it seems to have been fixed. The legacy option code was removed since if they disappear from the trade site searching for them is invalid anyway.
Steps taken to verify a working solution:
Link to a build that showcases this PR:
Before screenshot:
After screenshot: