fix: add missing Catarina veiled mods to Cane of Kulemak variants - #10033
Open
Maven35 wants to merge 3 commits into
Open
fix: add missing Catarina veiled mods to Cane of Kulemak variants#10033Maven35 wants to merge 3 commits into
Maven35 wants to merge 3 commits into
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The generated Cane of Kulemak only accepted veiled mods whose weightKey lists weapon/staff/two_hand_weapon with positive weight. Catarina's signature mods instead carry their weight on catarina_veiled_prefix and only list excluded slots, so five weapon-legal variants were missing, notably +2 to Level of Socketed Support Gems / +(5-8)% to Quality of Socketed Support Gems. Teach the filter to fall back to the pool weight key when no slot key matches, and re-point the default selected variants at the same mods as before. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The generated Cane of Kulemak only accepted veiled mods whose weightKey
lists weapon/staff/two_hand_weapon with positive weight. Catarina's
signature mods instead carry their weight on catarina_veiled_prefix and
only list excluded slots, so five weapon-legal variants were missing,
notably +2 to Level of Socketed Support Gems / +(5-8)% to Quality of
Socketed Support Gems. Teach the filter to fall back to the pool weight
key when no slot key matches, and re-point the default selected variants
at the same mods as before.
Co-Authored-By: Claude Fable 5 noreply@anthropic.com