feat: an external pull request needs two invited reviewers - #355
Merged
Conversation
The external-review required check enforces the maintainer's rule (iss-281): a PR whose author is not an invited collaborator (role triage or above) goes green only once two invited collaborators have approved — latest review state per reviewer decides, so a superseded approval does not count. A collaborator's own PR passes trivially, and bots keep the attribution gate's loud exemption. pull_request_target with no checkout, deliberately: the check runs the base repository's own logic, so a fork cannot edit the workflow green — the neutering hazard that rules out plain pull_request for a required check. The ruleset mirror gains the context; the live ruleset flips after this merges (a required check must exist on main before it is required, or every PR wedges on a check that never reports). Assisted-by: Claude:claude-fable-5
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
abcd | b376c82 | Aug 19 2026, 02:57 PM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What (iss-281 — the maintainer's hard rule for external contributions)
A new required check,
external-review:pull_request_targetwith no checkout — the check runs the base repo's own logic and only reads the reviews/roles API, so a fork cannot edit the workflow green (the neutering hazard that makes plainpull_requestunusable for a required check). zizmor's dangerous-triggers finding carries an inline ignore with the justification.Sequencing: the committed ruleset mirror already lists the new context; the live ruleset flips after this merges — a required check must exist on
mainbefore it is required, or every PR wedges on "Expected". Same bootstrap order as the merge queue.Issues half of the rule: GitHub-tracker issues have no native review gate; ledger captures land via PRs and inherit this rule — recorded in iss-281.
Verification
make preflightgreen (pre-push enforced)Assisted-by: Claude:claude-fable-5