Add board ID for Tustin Mach - #276
Conversation
30478bb to
3fcc244
Compare
|
Do all three boards exist already or are these plans for the future? |
They are at different stages of development:
So only Mach is fully validated at this point; Core is close to hardware validation, while Mini is still under design. |
|
@mrpollo if you prefer to reserve Board IDs only for boards that already physically exist, I’m also happy to keep this PR limited to Tustin Mach for now, and submit separate Board ID requests for Core and Mini once their hardware is ready. |
julianoes
left a comment
There was a problem hiding this comment.
Make sure to make a pull request to here as well:
https://github.com/ArduPilot/ardupilot/blob/master/Tools/AP_Bootloader/board_types.txt#L277
This tends to be the more authoritative place, to avoid any collisions.
3fcc244 to
8445c4d
Compare
That location is only authoritative for the ranges declared in the file. There's no contention merging outside those ranges as far as AP is concerned - if we get a PR outside the range I check over here and just get it merged in if it's been merged over here. In this case the ID is in the "ArduPilot range" - so it really, really should have been merged over there before this PR was created. I've just marked that other PR as "MergeOnCIPass" - but it's entirely possible that that PR could have conflicted with another allocation not-yet-merged-to-master - if this PR had been merged in that case we'd have a mess... |
It's been merged over there. |
Description
Add a new PX4 bootloader board ID for Tustin Mach flight controller.
Board
Tustin Mach
Board ID
TARGET_HW_TUSTIN_MACH = 1225