[BUG] Fix s5cmd action placing subcommand flags before the subcommand

[John McCall (lowlydba)]

--delete is a sync-subcommand flag in s5cmd, not a global one, so it has to come after sync (s5cmd sync --delete src dst). The flags input on .github/actions/s5cmd/action.yml is documented as global flags and always gets placed before the subcommand, so OvertureMaps/stac's publish-catalog.yaml passing flags: --delete broke production publishing:

Running: s5cmd --delete sync public_releases/ s3://overturemaps-extras-us-west-2/stac/
Incorrect Usage: flag provided but not defined: -delete

Fixes #83.

Adds a subcommand-flags input, placed after the subcommand and before source/destination. flags and its documented global-flag behavior are untouched, so this is backwards compatible. Guarded subcommand-flags against the run command in the validation step, since its batch-file lines carry their own per-command flags already.

Since OvertureMaps/stac pins this action @main and its publish-catalog.yaml still passes flags: --delete, that alone would still fail after merging (flags keeps its documented before-the-subcommand placement). Rather than requiring a coordinated follow-up PR there first, this also hardcodes a targeted auto-correction: if flags contains --delete and the command is sync, the action moves it after the subcommand automatically and logs a warning pointing callers at subcommand-flags. Anything else misplaced in flags still fails as before. Extend this case-by-case if more subcommand flags need the same treatment.

Verified the ARGS construction locally with bash, both against the new subcommand-flags input and against the existing flags: --delete shape stac's workflow currently uses; both build s5cmd sync --delete public_releases/ s3://overturemaps-extras-us-west-2/stac/ correctly. Not tested against a real S3 bucket.

[Copilot]

Pull request overview

This pull request fixes the .github/actions/s5cmd composite action’s argument ordering so subcommand-specific flags (e.g. sync --delete) can be placed after the subcommand, preventing production failures where subcommand flags were incorrectly treated as global flags.

Changes:

• Adds a new subcommand-flags input to pass flags after the subcommand and before positional args.
• Adds input validation to reject subcommand-flags when using the run command.
• Updates the ARGS construction to insert subcommand-flags between the subcommand and source/destination.

Suppressed comments (1)

.github/actions/s5cmd/action.yml:128

• The comment says “quote within flags if needed”, but the current read -ra ... <<< "$FLAGS" splitting does not honor shell-style quoting. Either update the comment to reflect whitespace-only splitting, or change parsing to a quote-aware approach.

        # Build argument array: global flags, then subcommand, then subcommand flags, then positional args
        ARGS=()

        # Word-split flags safely (simple space split; quote within flags if needed)
        if [[ -n "$FLAGS" ]]; then

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.