[BUG](ci) Tolerate no-package diff in the changelog fragment check - #636
Closed
Seth Fitzsimmons (sethfitz) wants to merge 1 commit into
Closed
[BUG](ci) Tolerate no-package diff in the changelog fragment check#636Seth Fitzsimmons (sethfitz) wants to merge 1 commit into
Seth Fitzsimmons (sethfitz) wants to merge 1 commit into
Conversation
The touched-packages pipeline ran grep -oE '^packages/[^/]+/' under set -euo pipefail. On a PR touching no package the grep matched nothing, exited 1, and the command substitution aborted the job with a bare exit 1 and no output -- a false failure indistinguishable from a real missing fragment. Guard the pipeline with || true, matching the has_* greps. Fixes #635 Signed-off-by: Seth Fitzsimmons <seth@mojodna.net>
Seth Fitzsimmons (sethfitz)
requested review from
a team and
John McCall (lowlydba)
as code owners
August 5, 2026 16:09
Seth Fitzsimmons (sethfitz)
added
the
automation 🦾
🗺️ Schema reference docs preview is live!
Note ♻️ This preview updates automatically with each push to this PR. |
John McCall (lowlydba)
approved these changes
Aug 5, 2026
Seth Fitzsimmons (sethfitz)
requested review from
Roel Bollens (RoelBollens-TomTom) and
Victor Schappert (vcschapp)
August 5, 2026 16:25
John McCall (lowlydba)
requested changes
Aug 6, 2026
John McCall (lowlydba)
left a comment
John McCall (lowlydba)
left a comment
Contributor
There was a problem hiding this comment.
I suggest closing this in favor of #645 which handles this + other latent concerns with the fragment check that need to be fixed for progressing the automation broadly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #635.
Problem
The
Require changelog on package changejob aborts with a bareexit 1on any PR whose diff touches no file underpackages/(a workflow-only, docs-only, or root-only change). Thetouchedpipeline runsgrep -oE "^packages/[^/]+/"underset -euo pipefail; with nopackages/path in the diff the grep matches nothing and exits 1, the command substitution inherits that status, andset -ekills the job before any output. The result is indistinguishable from a real missing-fragment failure: no::error::, no package list, just exit 1.The sibling
has_fragment/has_changelogsubstitutions already guard theirgrep -cwith|| true; thetouchedpipeline was missed.Observed on #626, a workflow-only publish fix, which was forced to carry a fragment to go green.
Change
Append
|| trueto thetouchedpipeline, matching the existing guard. Real detection is unaffected — a package changed without a fragment still fails.Verification
Ran the job logic against four diffs:
This PR is itself workflow-only. Because the check is
on: pull_request, it runs this PR's fixed workflow, so the job exercises the fix on its own diff.