Bake GIT_COMMIT_SHA into runner image#2939
Merged
Merged
Conversation
runContainer reports it as the runner's version, letting the Talos admin announce redeploys to Discord. Empty default keeps local builds working.
shahthepro
approved these changes
Jul 13, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2939 +/- ##
=======================================
Coverage 44.63% 44.63%
=======================================
Files 110 110
Lines 4920 4920
Branches 1362 1362
=======================================
Hits 2196 2196
Misses 2721 2721
Partials 3 3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bakes the build commit into the runner image so
@talos/client'srunContainerreports it as the runner'sversion(it readsGIT_COMMIT_SHA). This populatesrunners.versionin the shared Talos Postgres — null today — which the Talos admin uses to announce runner redeploys to Discord.Mirrors how the admin already bakes
TALOS_ADMIN_COMMIT:contracts/dockerfile-actions:ARG GIT_COMMIT_SHA=""+ENV GIT_COMMIT_SHA=$GIT_COMMIT_SHA(empty default keeps local builds working).aws-deployment.yml: CI passes--build-arg GIT_COMMIT_SHA=${{ github.sha }}.No
@talos/clientbump — the library already reads this env. Pairs with oplabs/talos#14.