Skip to content

Remove non-working workflow#51

Merged
Sharpie merged 1 commit into
mainfrom
remove-non-working-workflow
May 28, 2026
Merged

Remove non-working workflow#51
Sharpie merged 1 commit into
mainfrom
remove-non-working-workflow

Conversation

@smortex
Copy link
Copy Markdown
Member

@smortex smortex commented Aug 25, 2025

This workflow fail to start because of missing dependencies:

Unhandled error: TypeError: Cannot read properties of undefined (reading 'listWorkflowRunArtifacts')

Additionally, on the upstream repo, this workflow is broken:
https://github.com/puppetlabs/puppet-runtime/actions/workflows/comment_on_pr.yaml

There is no point in keeping it.

Fixes: #37

@bastelfreak
Copy link
Copy Markdown
Contributor

I initially didn't remove it because I wasn't sure if it would be worth fixing it. I'm still undecided.

Copy link
Copy Markdown
Member

@Sharpie Sharpie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this workflow was set up to be triggered by the Vanagon Component Diff workflow, which was removed in commit 21eb9cc.

So, it is truly dead code at this point.

This workflow fail to start because of missing dependencies:

> Unhandled error: TypeError: Cannot read properties of undefined (reading 'listWorkflowRunArtifacts')

Additionally, on the upstream repo, this workflow is broken:
https://github.com/puppetlabs/puppet-runtime/actions/workflows/comment_on_pr.yaml

There is no point in keeping it.

Fixes: #37
Signed-off-by: Charlie Sharpsteen <charlie@overlookinfratech.com>
@Sharpie Sharpie force-pushed the remove-non-working-workflow branch from b519d4b to dc7cb73 Compare May 28, 2026 12:50
@Sharpie Sharpie enabled auto-merge May 28, 2026 12:51
@Sharpie Sharpie merged commit 552a022 into main May 28, 2026
43 checks passed
@Sharpie Sharpie deleted the remove-non-working-workflow branch May 28, 2026 13:09
@Sharpie Sharpie added the skip-changelog Excluded from CHANGELOG label May 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changelog Excluded from CHANGELOG

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Failing "Comment output on PR" action on Pull Requests

3 participants